Use Sleuth API for Redis instrumentation #2046
Conversation
Extracted Brave-specific Redis instrumentation to use the Sleuth API, and registered the implementation in Brave autoconfiguration. Fixes gh-2045
|
There was an error in my PR. I've just fixed it. |
| @@ -14,27 +14,25 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package org.springframework.cloud.sleuth.brave.instrument.redis; | |||
| package org.springframework.cloud.sleuth.instrument.redis; | |||
There was a problem hiding this comment.
That's a breaking change. I think we need to leave this one here and create a new copy in the new package.
There was a problem hiding this comment.
Thanks for the review. How about the ClientResourcesBuilderCustomizer interface. Is it ok that I moved it to the new package or should I duplicate that, too?
| @@ -66,7 +66,9 @@ DefaultClientResources traceLettuceClientResources(ObjectProvider<ClientResource | |||
| TraceLettuceClientResourcesBuilderCustomizer traceLettuceClientResourcesBuilderCustomizer(Tracing tracing, | |||
There was a problem hiding this comment.
We would need a new autoconfiguration that references the new ...cloud.sleuth.instrument.redis... instrumentation that does not use Brave directly. The old TraceLettuceClientResourcesBuilderCustomizer should not be registered as a bean at all (this is a breaking change but that class should not be referenced by users). In BraveRedisAutoConfiguration.java we would need to create a bean of BraveTracing type and in OTel we would have the OtelTracing version.
There was a problem hiding this comment.
If I understood correctly, I should remove the old TraceLettuceClientResourcesBuilderCustomizer bean registration and register two additional beans: BraveTracing and the new TraceLettuceClientResourcesBuilderCustomizer. Would that be correct?
|
Done via a08f94c |
Extracted Brave-specific Redis instrumentation to use the Sleuth API, and registered the implementation in Brave autoconfiguration.
Fixes gh-2045