Skip to content

Inconsistent usage of application configuration #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snicoll opened this issue Aug 16, 2018 · 2 comments
Open

Inconsistent usage of application configuration #186

snicoll opened this issue Aug 16, 2018 · 2 comments

Comments

@snicoll
Copy link

snicoll commented Aug 16, 2018

Someone on Gitter was following this tutorial and got confused by the fact the project does not contain an application.yml. Most of the tutorial is using application.properties and only a few places are using yaml.

Considering the default is properties perhaps the few parts that were written with YAML can be harmonized so that only properties is used. We can, of course, add a note about the YAML support if that's necessary.

@dsyer
Copy link
Collaborator

dsyer commented Aug 17, 2018

Some of the projects in this guide use Zuul, and the route configuration looks much better IMO in YAML, so I think we should keep it that way. I'd be more than happy to clarify that in the text if you can point at the original source of confusion more precisely.

@snicoll
Copy link
Author

snicoll commented Aug 17, 2018

the route configuration looks much better IMO in YAML

I don't disagree with that but if a user follows the guide and don't know about this, this is super confusing to have 90% of the example with one format and the minority with others. There is no real explanation about it either so this may just as well be two totally different files for a newcomer.

The only section I found is this:

Starting from the blank Initializr application, we add the Spring Session dependency (like in the UI above). The Gateway is ready to run, but it doesn’t yet know about our backend services, so let’s just set that up in its application.yml (renaming from application.properties if you did the curl thing above):

The renaming applies to every way the app is created by initializr (IDE, web UI, command line) so I don't really understand why this text focuses on curl. If you want to stick with YAML then I'd argue everything should have this format. My preference would be properties all the way with a note about YAML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants