Skip to content

Upgrade to CheckStyle 8.45 #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leikingo opened this issue May 25, 2021 · 0 comments
Closed

Upgrade to CheckStyle 8.45 #275

leikingo opened this issue May 25, 2021 · 0 comments
Assignees
@wilkinsona
Labels
type: dependency-upgrade
Milestone
0.0.29

Comments

@leikingo
Copy link

leikingo commented May 25, 2021 •
edited
Loading

Due to a backward incompatible change in the CheckStyle API ( Rename LocalizedMessage to violations ) with the recent CheckStyle release, SpringChecks.processFiltered fails with CheckStyle version 8.42. It seems that AbstractFileSetCheck.addMessages is now AbstractFileSetCheck.addViolations. Since this is a breaking change, the minimum CheckStyle would also have to be increased to 8.42.
@leikingo leikingo changed the title Fails with CheckStyle 8.43 Fails with CheckStyle 8.42 May 25, 2021
@philwebb philwebb added this to the 0.0.x milestone May 25, 2021
@philwebb philwebb changed the title Fails with CheckStyle 8.42 Upgrade to CheckStyle 8.42 May 25, 2021
@wilkinsona wilkinsona self-assigned this Sep 23, 2021
@wilkinsona wilkinsona changed the title Upgrade to CheckStyle 8.42 Upgrade to CheckStyle 8.45 Sep 23, 2021
@wilkinsona wilkinsona modified the milestones: 0.0.x, 0.0.29 Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: dependency-upgrade
Projects
None yet
Milestone
0.0.29
Development

No branches or pull requests
3 participants
@philwebb @wilkinsona @leikingo