Skip to content

please make the SQL tables that are generated - in at least the JdbcChatMemory and the PgVectorStore implementations - consistent. #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshlong opened this issue May 3, 2025 · 5 comments
Milestone

Comments

@joshlong
Copy link
Member

joshlong commented May 3, 2025

please make the SQL tables that are generated - in at least the JdbcChatMemory and the PgVectorStore implementations - consistent.

AI_CHAT_MEMORY
SPRING_AI_VECTORS

Maybe SPRING_AI_CHAT_MEMORY as a useful default?

@markpollack
Copy link
Member

moreover the schema needs to be customizable.

@markpollack markpollack added this to the 1.0.0-RC1 milestone May 3, 2025
@joshlong
Copy link
Member Author

joshlong commented May 4, 2025

Yah. Customization is good. The schema for the existing supported databases aren’t easily overridden. Schema for unsupported databases however are easy to provide: just add a .sql file in the class the sql initializer would look for it /src/man/resources/org/springframework/ai/blah/schema-oracle.sql

The initialiser substitutes the platform name in the file name. That already ‘just works’

I don’t know (I’m afk) if there’s a way to tell our various JDBC-backed things to back off for the databases we do support. I’d be surprised if we didn’t. Don’t we have initialize-schema=true or something ?

@quaff
Copy link
Contributor

quaff commented May 6, 2025

Don’t we have initialize-schema=true or something ?

FYI, Spring Boot use enum DatabaseInitializationMode instead of boolean, and default to EMBEDDED, I'm trying to create PR to align with Boot.

@quaff
Copy link
Contributor

quaff commented May 6, 2025

Don’t we have initialize-schema=true or something ?

FYI, Spring Boot use enum DatabaseInitializationMode instead of boolean, and default to EMBEDDED, I'm trying to create PR to align with Boot.

Created #3010.

@markpollack
Copy link
Member

closing as this PR #3055 address the issue and we have a few issues on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants