Skip to content

Commit c82aace

Browse files
committed
Polish tests
Issue gh-1925
1 parent 39cb9bf commit c82aace

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2AuthorizationCodeRequestAuthenticationProviderTests.java

+1-8
Original file line numberDiff line numberDiff line change
@@ -638,8 +638,6 @@ public void authenticateWhenAuthorizationCodeRequestWithRequestUriThenReturnAuth
638638
@Test
639639
public void authenticateWhenAuthorizationCodeRequestWithInvalidRequestUriThenThrowOAuth2AuthorizationCodeRequestAuthenticationException() {
640640
RegisteredClient registeredClient = TestRegisteredClients.registeredClient().build();
641-
given(this.registeredClientRepository.findByClientId(eq(registeredClient.getClientId())))
642-
.willReturn(registeredClient);
643641

644642
OAuth2PushedAuthorizationRequestUri pushedAuthorizationRequestUri = OAuth2PushedAuthorizationRequestUri
645643
.create();
@@ -664,12 +662,7 @@ public void authenticateWhenAuthorizationCodeRequestWithInvalidRequestUriThenThr
664662
@Test
665663
public void authenticateWhenAuthorizationCodeRequestWithRequestUriIssuedToAnotherClientThenThrowOAuth2AuthorizationCodeRequestAuthenticationException() {
666664
RegisteredClient registeredClient = TestRegisteredClients.registeredClient().build();
667-
given(this.registeredClientRepository.findByClientId(eq(registeredClient.getClientId())))
668-
.willReturn(registeredClient);
669-
670665
RegisteredClient anotherRegisteredClient = TestRegisteredClients.registeredClient2().build();
671-
given(this.registeredClientRepository.findByClientId(eq(anotherRegisteredClient.getClientId())))
672-
.willReturn(anotherRegisteredClient);
673666

674667
OAuth2PushedAuthorizationRequestUri pushedAuthorizationRequestUri = OAuth2PushedAuthorizationRequestUri
675668
.create();
@@ -688,7 +681,7 @@ public void authenticateWhenAuthorizationCodeRequestWithRequestUriIssuedToAnothe
688681
assertThatThrownBy(() -> this.authenticationProvider.authenticate(authentication))
689682
.isInstanceOf(OAuth2AuthorizationCodeRequestAuthenticationException.class)
690683
.satisfies((ex) -> assertAuthenticationException((OAuth2AuthorizationCodeRequestAuthenticationException) ex,
691-
OAuth2ErrorCodes.INVALID_REQUEST, "client_id", null));
684+
OAuth2ErrorCodes.INVALID_REQUEST, OAuth2ParameterNames.CLIENT_ID, null));
692685
}
693686

694687
@Test

0 commit comments

Comments
 (0)