Skip to content

LobCreatorArgumentPreparedStatementSetter class is duplicated #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sjohnr opened this issue Jun 22, 2021 · 2 comments
Closed

LobCreatorArgumentPreparedStatementSetter class is duplicated #320

sjohnr opened this issue Jun 22, 2021 · 2 comments
Assignees
@sjohnr
Labels
status: invalid An issue that we don't feel is valid

Comments

@sjohnr
Copy link
Contributor

sjohnr commented Jun 22, 2021

LobCreatorArgumentPreparedStatementSetter is duplicated in the following locations:

  • JdbcOAuth2AuthorizationService
  • JdbcRegisteredClientRepository

It is also duplicated in spring-security:

  • JdbcOAuth2AuthorizedClientService

Ideally, it would exist in only one location, possibly spring-security-oauth2-core.
@sjohnr sjohnr added the type: enhancement A general enhancement label Jun 22, 2021
@sjohnr
Copy link
Contributor Author

sjohnr commented Jun 22, 2021

This was suggested in discussion on #291.

@sjohnr
Copy link
Contributor Author

sjohnr commented Jun 28, 2021

At the moment, this is no longer the case due to 67e62a2. In light of that, I'm going to close this for now.

@sjohnr sjohnr closed this as completed Jun 28, 2021
@jgrandja jgrandja added status: invalid An issue that we don't feel is valid and removed type: enhancement A general enhancement labels Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjohnr sjohnr

Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjohnr @jgrandja