Skip to content

Use BulkOperations API in MongoItemWriter #3713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fmbenhassine opened this issue May 18, 2020 · 6 comments
Closed

Use BulkOperations API in MongoItemWriter #3713

fmbenhassine opened this issue May 18, 2020 · 6 comments

Comments

@fmbenhassine
Copy link
Contributor

fmbenhassine commented May 18, 2020

As of v4.2, the MongoItemWriter uses a for loop to save items through the mongo template. Using org.springframework.data.mongodb.core.BulkOperations should give better performance.

It should be noted that template.save is an upsert operation, so we need to use an equivalent operation in the BulkOperations API.

Reference: https://stackoverflow.com/questions/61644406

@parikshitdutta
Copy link
Contributor

parikshitdutta commented May 18, 2020

Hi @benas, may I look into this one?

@fmbenhassine
Copy link
Contributor Author

Sure, you are welcome. I assigned it to you. Thank you!

@parikshitdutta
Copy link
Contributor

Hi @benas , regret taking longer, super cyclone massacred our place last week. Anyways, please have a look at PR #3721. I will look forward to your feedback.

Thank you.

@fmbenhassine
Copy link
Contributor Author

@parikshitdutta oh sorry for that I hope you are safe! No worries, I will let you know once I start working on your PR. Thank you.

@parikshitdutta
Copy link
Contributor

Hi @benas, we are blessed to be safe and secure, otherwise it has devastated our place! Things getting back to normal. Thanks for asking and caring.

@fmbenhassine
Copy link
Contributor Author

Resolved with #3721.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants