Fix RedisAutoConfiguration with pool config

fixes #850

Author: cdupuis

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/redis/RedisAutoConfiguration.java

@@ -42,6 +42,7 @@
  *
  * @author Dave Syer
  * @author Andy Wilkinson
+ * @author Christian Dupuis
  */
 @Configuration
 @ConditionalOnClass({ JedisConnection.class, RedisOperations.class, Jedis.class })
@@ -79,12 +80,13 @@ protected static class RedisPooledConnectionConfiguration {
 		@Bean
 		@ConditionalOnMissingBean
 		RedisConnectionFactory redisConnectionFactory() throws UnknownHostException {
-			if (this.properties.getPool() != null) {
-				JedisConnectionFactory factory = new JedisConnectionFactory(
-						jedisPoolConfig());
-				return factory;
+			JedisConnectionFactory factory = null;
+			if (this.properties.getPool() == null) {
+				factory = new JedisConnectionFactory();
+			}
+			else {
+				factory = new JedisConnectionFactory(jedisPoolConfig());
 			}
-			JedisConnectionFactory factory = new JedisConnectionFactory();
 			factory.setHostName(this.properties.getHost());
 			factory.setPort(this.properties.getPort());
 			if (this.properties.getPassword() != null) {

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/redis/RedisAutoConfigurationTests.java

@@ -29,6 +29,7 @@
 
 /**
  * @author Dave Syer
+ * @author Christian Dupuis
  */
 public class RedisAutoConfigurationTests {
 
@@ -55,4 +56,18 @@ public void testOverrideRedisConfiguration() throws Exception {
 				.getHostName());
 	}
 
+	@Test
+	public void testRedisConfigurationWithPool() throws Exception {
+		this.context = new AnnotationConfigApplicationContext();
+		EnvironmentTestUtils.addEnvironment(this.context, "spring.redis.host:foo");
+		EnvironmentTestUtils.addEnvironment(this.context, "spring.redis.pool.max-idle:1");
+		this.context.register(RedisAutoConfiguration.class,
+				PropertyPlaceholderAutoConfiguration.class);
+		this.context.refresh();
+		assertEquals("foo", this.context.getBean(JedisConnectionFactory.class)
+				.getHostName());
+		assertEquals(1, this.context.getBean(JedisConnectionFactory.class)
+				.getPoolConfig().getMaxIdle());
+	}
+
 }