Skip to content

SpringIntegrationMetrics calls configurer.afterSingletonsInstantiated() directly #10286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Sep 13, 2017 · 1 comment
Closed

SpringIntegrationMetrics calls configurer.afterSingletonsInstantiated() directly #10286

philwebb opened this issue Sep 13, 2017 · 1 comment
Assignees
@mbhave
Labels
type: task A general task
Milestone
2.0.0.M5

Comments

@philwebb
Copy link
Member

The SpringIntegrationMetrics class currently calls this.configurer.afterSingletonsInstantiated(); directly. We seem to be getting away with it, but probably by accident rather than design.
@philwebb philwebb added this to the 2.0.0.M5 milestone Sep 13, 2017
@mbhave mbhave self-assigned this Oct 3, 2017
@mbhave mbhave closed this as completed in ad2f774 Oct 4, 2017
@mbhave
Copy link
Contributor

mbhave commented Oct 4, 2017

IntegrationManagementConfigurer is registered before SpringIntegrationMetrics so IntegrationManagementConfigurer#afterSingletonsInstantiated will be called before SpringIntegrationMetrics#afterSingletonsInstantiated. Need to confirm with @jhoeller that the ordering is guaranteed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbhave mbhave

Labels
type: task A general task
Projects
None yet
Milestone
2.0.0.M5
Development

No branches or pull requests
3 participants
@philwebb @wilkinsona @mbhave