Skip to content

Migration guide missing crucial change #11850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanderino666 opened this issue Jan 30, 2018 · 2 comments
Closed

Migration guide missing crucial change #11850

sanderino666 opened this issue Jan 30, 2018 · 2 comments
Labels
status: duplicate A duplicate of another issue

Comments

@sanderino666
Copy link

Hi guys,

We are trying out the Spring Boot migration from 1.5.9 to 2.0.0.M7 and we noticed a change in the documentation which isn't mentioned in the migration guide but is actually pretty substantial and worthy of mentioning.

Spring boot 1.5.9
https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#boot-features-external-config-application-property-files

When custom config locations are configured, they are used in addition to the default locations

Spring boot 2.0.0
https://docs.spring.io/spring-boot/docs/current-SNAPSHOT/reference/htmlsingle/#boot-features-external-config-application-property-files

When custom config locations are configured by using spring.config.location, they replace the default locations

It took us a while to figure out why our properties from the classpath aren't loaded when setting the spring.config.location so I would imagine other people will encounter the same problem.

BTW: Looking forward to the RC1 :). Spring boot rocks!

Regards,

Sander

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 30, 2018
@snicoll
Copy link
Member

snicoll commented Jan 30, 2018

It is actually described in the release notes for M6

The migration guide is still in progress. Duplicate of #10313

@snicoll snicoll closed this as completed Jan 30, 2018
@snicoll snicoll added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 30, 2018
@bclozel
Copy link
Member

bclozel commented Jan 31, 2018

Done here. Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants