Skip to content

Deprecate @ConfigurationProperties#ignoreUnknownFields #12601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Mar 22, 2018 · 3 comments
Closed

Deprecate @ConfigurationProperties#ignoreUnknownFields #12601

snicoll opened this issue Mar 22, 2018 · 3 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@snicoll
Copy link
Member

snicoll commented Mar 22, 2018 •
edited by wilkinsona
Loading

ignoreUnknownFields allows to spot cases where a property on the target namespace was left unbound. It is an interesting feature with a serious limitation (#3445) that means we hardly use it in practice.

We should consider deprecating it in the next feature release.
@snicoll snicoll added the type: task A general task label Mar 22, 2018
@snicoll snicoll added this to the Backlog milestone Mar 22, 2018
@snicoll snicoll mentioned this issue Mar 22, 2018
Closed
@wilkinsona wilkinsona changed the title Consider deprecating @ConfigurationProperties#ignoreUnknownFields Deprecate @ConfigurationProperties#ignoreUnknownFields Jun 1, 2018
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed type: task A general task labels Jun 1, 2018
@snicoll snicoll assigned snicoll and unassigned snicoll Jun 1, 2018
@snicoll
Copy link
Member Author

snicoll commented Jun 5, 2018

Trying to come up with a deprecated message for this, I think it would be more fair to deprecate it when we tackle #10030

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Jun 5, 2018
@philwebb philwebb added status: blocked An issue that's blocked on an external project change and removed for: team-attention An issue we'd like other members of the team to review labels Jun 6, 2018
@philwebb philwebb removed this from the Backlog milestone Jun 6, 2018
@snicoll snicoll added this to the Icebox milestone Jun 6, 2018
@thombergs
Copy link
Contributor

I noticed that ignoreUnknownFields=false does not work when ignoreInvalidFields is set to true.

It seems that as soon as invalid fields are ignored, unknown fields are also ignored, no matter what the value of ignoreUnknownFields, which is not what I would expect.

Since ignoreUnknownFields will be deprecated, I didn't want to raise a new issue, but wanted to document it here in case anyone else stumbles upon this.

@copitz copitz mentioned this issue Oct 25, 2019
Open
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement labels Jul 13, 2020
@philwebb
Copy link
Member

@thombergs We're going to fix the issue you mention in #22308

@snicoll snicoll removed this from the General Backlog milestone Jul 13, 2020
@bowsersenior bowsersenior mentioned this issue Sep 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snicoll @philwebb @wilkinsona @thombergs