Skip to content

CompositeReactiveHealthIndicatorTests.timeoutReachedUsesFallback is flaky on Windows #23093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Aug 26, 2020 · 0 comments
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

This relates to reactor/reactor-core#2297. With thanks to @SBasle and @bsideup for the analysis, it appears that the precision of Windows' timer degrades significantly under load such that a 100ms timeout may be missed. The recommendation is to stabilise the test be increasing the timeout and delay periods to reduce the likelihood of them being less than Windows' timing precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant