Skip to content

Make more use of AssertJ's built-in map assertions #24970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Jan 22, 2021 · 0 comments
Closed

Make more use of AssertJ's built-in map assertions #24970

wilkinsona opened this issue Jan 22, 2021 · 0 comments
Assignees
@wilkinsona
Labels
type: task A general task
Milestone
2.3.9

Comments

@wilkinsona
Copy link
Member

We have a few places in our tests where we call assertThat(map.containsKey(key)).isFalse(). We should use AssertJ's built-in doesNotContainKey(key) assertion instead.
@wilkinsona wilkinsona added the type: task A general task label Jan 22, 2021
@wilkinsona wilkinsona added this to the 2.3.x milestone Jan 22, 2021
@wilkinsona wilkinsona self-assigned this Jan 22, 2021
@wilkinsona wilkinsona changed the title Use assertThat(map).doesNotContainKey(key) rather than assertThat(map.containsKey(key)).isFalse() Make more use of AssertJ's built-in map assertions Jan 22, 2021
@wilkinsona wilkinsona mentioned this issue Jan 22, 2021
Closed
@wilkinsona wilkinsona modified the milestones: 2.3.x, 2.3.9 Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: task A general task
Projects
None yet
Milestone
2.3.9
Development

No branches or pull requests
1 participant
@wilkinsona