Skip to content

Drop support for String path matching for MVC endpoint handler mappings #31700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbhave opened this issue Jul 13, 2022 · 1 comment
Closed
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@mbhave
Copy link
Contributor

mbhave commented Jul 13, 2022

I tried to do this as part of #31547 but reverted the endpoint specific changes because the changes were bigger than expected. The handler mappings support both path pattern and string based matching with path pattern used by the auto-configuration. In case of String-based matching, trailing slashes are supported but that does not seem to be the case with pattern based matching. As part of this issue, we need to do the following:

  • Drop support for String based matching for actuator endpoints
  • Consider whether to support trailing slash for actuator endpoints with pattern matching
  • AbstractWebMvcEndpointHandlerMapping no longer needs to be a MatchableHandlerMapping (this was added to support Spring Security's MvcRequestMatcher but it can do that now without it being a MatchableHandlerMapping).
@mbhave mbhave added the status: waiting-for-triage An issue we've not yet triaged label Jul 13, 2022
@wilkinsona
Copy link
Member

There may be some overlap between this issue and #31604.

@wilkinsona wilkinsona changed the title Consider dropping support for String path matching for MVC endpoint handler mappings Drop support for String path matching for MVC endpoint handler mappings Jul 13, 2022
@wilkinsona wilkinsona added type: enhancement A general enhancement status: ideal-for-contribution An issue that a contributor can help us with and removed status: waiting-for-triage An issue we've not yet triaged status: ideal-for-contribution An issue that a contributor can help us with labels Jul 13, 2022
@wilkinsona wilkinsona added this to the 3.0.x milestone Jul 13, 2022
@mbhave mbhave self-assigned this Jul 13, 2022
@mbhave mbhave modified the milestones: 3.0.x, 3.0.0-M4 Jul 13, 2022
@mbhave mbhave closed this as completed in 7c56a45 Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants