Skip to content

Wrong timeunit for timeouts in Zipkins URLConnectionSender #31957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhalbritter opened this issue Aug 2, 2022 · 0 comments
Closed

Wrong timeunit for timeouts in Zipkins URLConnectionSender #31957

mhalbritter opened this issue Aug 2, 2022 · 0 comments
Assignees
@mhalbritter
Labels
type: bug A general bug
Milestone
3.0.0-M5

Comments

@mhalbritter
Copy link
Contributor

The org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinConfigurations.UrlConnectionSenderConfiguration#urlConnectionSender auto-configuration feeds the timeouts for connect and read to the URLConnectionSender as seconds. URLConnectionSender needs them as milliseconds though.
@mhalbritter mhalbritter added the type: bug A general bug label Aug 2, 2022
@mhalbritter mhalbritter added this to the 3.0.0-M5 milestone Aug 2, 2022
@mhalbritter mhalbritter self-assigned this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
type: bug A general bug
Projects
None yet
Milestone
3.0.0-M5
Development

No branches or pull requests
1 participant
@mhalbritter