Skip to content

Align default JMX endpoint exposure with default web endpoint exposure #32005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Aug 8, 2022 · 5 comments
Closed
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

We currently expose more endpoints by default over JMX than we do over the web. For consistency, we've decided to change the default exposure over JMX to align it with the default exposure over the web.

@wilkinsona wilkinsona added the type: enhancement A general enhancement label Aug 8, 2022
@wilkinsona wilkinsona added this to the 3.0.x milestone Aug 8, 2022
@mbhave mbhave self-assigned this Aug 16, 2022
@mbhave mbhave modified the milestones: 3.0.x, 3.0.0-M5 Aug 16, 2022
@mbhave mbhave closed this as completed in cea6492 Aug 16, 2022
@kaleev
Copy link

kaleev commented Nov 8, 2022

@mbhave, could you please also fix defaultValue for management.endpoints.jmx.exposure.include in additional-spring-configuration-metadata.json?

@philwebb
Copy link
Member

philwebb commented Nov 8, 2022

@kaleev I've opened #33072

@gmuth
Copy link

gmuth commented Nov 9, 2022

I understand the idea, however considering that JMX by default is only exposed locally and Web is exposed to remote connections it should be okay to have different default settings IMHO.

This change has an immediate impact on IDEs integrating with spring boot actuators via JMX. Intellij IDEA notifies on application start up about missing endpoint data. Developers now have to explicitly enable those endpoints:

# file: application.properties
# fix IntelliJ IDEA actuator tool issues:
# "Failed to receive 'mappings' endpoint data" 
# "Failed to retrieve 'beans' endpoint data"
management.endpoints.jmx.exposure.include=mappings,beans

This should at least be clarified in the reference documentation or/and in the "Migrate to SpringBoot 3.0" documentation.

@wilkinsona
Copy link
Member Author

@gmuth It's already mentioned in the release notes in the "Upgrading from Spring Boot 2.x" section.

@kaleev
Copy link

kaleev commented Nov 10, 2022

@gmuth it has been already fixed in Intellij IDEA: https://youtrack.jetbrains.com/issue/IDEA-301274
The fix will be included in the upcoming release 2022.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants