Skip to content

Change B3 extraction format to SINGLE #35674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhalbritter opened this issue May 30, 2023 · 8 comments
Closed

Change B3 extraction format to SINGLE #35674

mhalbritter opened this issue May 30, 2023 · 8 comments
Assignees
@KitBolourchi
Labels
status: superseded An issue that has been superseded by another

Comments

@mhalbritter
Copy link
Contributor

Right now, we're using B3Propagation.Format.SINGLE_NO_PARENT. We should change this to SINGLE.

See this discussion.
@mhalbritter mhalbritter added type: enhancement A general enhancement theme: observability Issues related to observability labels May 30, 2023
@mhalbritter mhalbritter added this to the 3.2.x milestone May 30, 2023
@mhalbritter mhalbritter mentioned this issue May 30, 2023
Closed
@KitBolourchi
Copy link
Contributor

Hey @mhalbritter, I would be happy to look into this issue. Please assign it to me :)

@scottfrederick
Copy link
Contributor

Thanks @KitBolourchi, I've assigned the issue to you. We have not yet created the branches to start 3.2.x development, so we won't be able to accept a contribution for a while.

@KitBolourchi
Copy link
Contributor

Hey @scottfrederick, no problem at all! Would you recommend I make the change and create a PR which can be merged when ready or wait until you are ready before raising the PR?

@mhalbritter
Copy link
Contributor Author

mhalbritter commented Jun 5, 2023 •
edited
Loading

#35611 will move some things around, so please hold off until this PR is merged, otherwise there will be quite some merge conflicts.

@philwebb philwebb mentioned this issue Jun 7, 2023
Closed
31 tasks
@KitBolourchi
Copy link
Contributor

Gotcha I understand, I will hold off until the release branch is ready!

@mhalbritter
Copy link
Contributor Author

mhalbritter commented Jun 15, 2023 •
edited
Loading

#35611 is merged, you can start now :)

@KitBolourchi
Copy link
Contributor

Great, I will get started on this shortly :) Thanks

@KitBolourchi KitBolourchi mentioned this issue Jun 24, 2023
Closed
@mhalbritter
Copy link
Contributor Author

Superseded by #36061

@mhalbritter mhalbritter closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2023
@mhalbritter mhalbritter removed this from the 3.2.x milestone Jun 26, 2023
@mhalbritter mhalbritter added status: superseded An issue that has been superseded by another and removed type: enhancement A general enhancement theme: observability Issues related to observability labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitBolourchi KitBolourchi

Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scottfrederick @KitBolourchi @mhalbritter