-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Percentiles not published after inlcuding spring batch dependency #43049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can't reproduce the behaviour that you have described. For example, here's a snippet of the output from the Prometheus endpoint showing the two percentiles configured in application.yaml:
I did notice numerous warnings about beans being ineligible for post-processing:
I think it's possible that with some different configuration to what I tried that this may be the cause of your problem. It has been addressed in spring-projects/spring-batch#4547 in Spring Batch 5.2. If I upgrade to Spring Boot 3.4.0-RC1 the warnings are no longer produced. Please try your app where the percentiles are not published with Spring Boot 3.4.0-RC1 (available from https://repo.spring.io/milestone). If the problem no longer occurs then it very likely that the problem in Spring Batch was the cause. If the problem still occurs then the cause is likely to be something else and if you want us to investigate further you will have to provide a complete yet minimal sample that reproduces the problem. |
I tested Spring Boot 3.4.0-RC1 and the issue is resolved. So it looks like the problem is in spring batch. |
Thanks for trying the RC and for letting us know. I'll close this one now then as there's nothing that can be done in Spring Boot. You may want to open a Spring Batch issue to see if the problem can be addressed somehow in versions prior to 5.2. /cc @fmbenhassine. |
Spring boot 3.2.6 (also tried under 3.3.5).
On the app config I have
And I was getting percentiles on my metrics.
After adding the following dependency:
Percentiles stopped being published (unless I explicitly add the percentiles in java code).
The text was updated successfully, but these errors were encountered: