Skip to content

Delete AutoConfigurationReproTests as testing for early init is covered by WebServerFactoryCustomizerBeanPostProcessorTests #44511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Mar 3, 2025 · 3 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

When AutoConfigurationReproTests was introduced, it was testing some code in EmbeddedServletContainerAutoConfiguration that registered a EmbeddedServletContainerCustomizerBeanPostProcessor bean if one had not already been defined. That post-processor has now become WebServerFactoryCustomizerBeanPostProcessor that's registered by ReactiveWebServerFactoryAutoConfiguration or ServletWebServerFactoryAutoConfiguration.

@wilkinsona wilkinsona self-assigned this Mar 3, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Mar 3, 2025
@wilkinsona wilkinsona added the type: task A general task label Mar 3, 2025
@siripuramGanesh

This comment has been minimized.

@wilkinsona

This comment has been minimized.

@wilkinsona
Copy link
Member Author

In fact, we can delete the class entirely as the post-processor and the potential for it to trigger early initialization is covered by WebServerFactoryCustomizerBeanPostProcessorTests.

@wilkinsona wilkinsona changed the title Move AutoConfigurationReproTests nearer to the code that it's testing Delete AutoConfigurationReproTests as testing for early init is covered by WebServerFactoryCustomizerBeanPostProcessorTests Mar 4, 2025
@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.10 Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants