Remove buildConsumerProperties(SslBundles) from KafkaProperties

[Renboo]

Spring boot 3.5.0

I found that KafkaProperties.java lost this part:

private Map<String, Object> buildPropertiesForSslBundle(SslBundles sslBundles, String name) {
	Properties properties = new Properties();
	properties.in(SslConfigs.SSL_ENGINE_FACTORY_CLASS_CONFIG).accept(SslBundleSslEngineFactory.class);
	properties.in(SslBundle.class.getName()).accept(sslBundles.getBundle(name));
	return properties;
}

And after this logged consumer config values will contain
ssl.engine.factory.class = null
and SSL Handshake exception.

In previous 3.4.x all work greate.

To understand the whole story I use buildConsumerProperties(sslBundles) method to create Kafkfa config.

Is it bug or feature?

[wilkinsona]

The first thing to note here is that the methods on Spring Boot's @ConfigurationProperties classes are not considered to be public API:

The properties that map to @ConfigurationProperties classes available in Spring Boot, which are configured through properties files, YAML files, environment variables, and other mechanisms, are public API but the accessors (getters/setters) of the class itself are not meant to be used directly.

As you're using methods on KafkaProperties, you are being affected by the change made in dae891f. Applying the properties for the SSL bundle is now done in KafkaAutoConfiguration. You will have to adapt your own code to match.

[Renboo]

@wilkinsona thank you!

But to be honest buildConsumerProperties(sslBundles) should be deleted from KafkaProperties, am i right?
It is useless without
properties.in(SslConfigs.SSL_ENGINE_FACTORY_CLASS_CONFIG).accept(SslBundleSslEngineFactory.class);

[wilkinsona]

Yes, I think you're right. We can use this issue to do that.

[Torres-09]

Hi, I’d like to work on this issue. Let me know if it's okay to proceed.

[wilkinsona]

It's all yours, @Torres-09. Thanks!

[wilkinsona]

Closing in favor of #45727. Thanks for the PR, @Torres-09.