Skip to content

Consider adding Spring Session starter #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vpavic opened this issue May 31, 2016 · 4 comments
Closed

Consider adding Spring Session starter #6082

vpavic opened this issue May 31, 2016 · 4 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@vpavic
Copy link
Contributor

vpavic commented May 31, 2016

Since Spring Boot provides auto-configuration capabilities for Spring Session, it might be useful to add a starter module.

See vpavic/spring-boot@947fbbc. If this approach is acceptable I can submit the PR based on this commit.

Alternatively, vpavic/spring-boot@a2e8453 adds multiple starters, one for each supported repository backend, however IMO a single starter is better and much simpler option.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 31, 2016
@philwebb philwebb added for: team-attention An issue we'd like other members of the team to review waiting-for-votes and removed status: waiting-for-triage An issue we've not yet triaged for: team-attention An issue we'd like other members of the team to review labels Jun 7, 2016
@philwebb
Copy link
Member

philwebb commented Jun 7, 2016

I'm not convinced that we really need one for spring-session since it's a one-line dependency anyway. I'll tag this as waiting-for-votes to see what the general feeling is.

@vpavic
Copy link
Contributor Author

vpavic commented Jun 13, 2016

I'm not convinced that we really need one for spring-session since it's a one-line dependency anyway.

You do need the web stack as well, hence also the spring-boot-starter-web dependency.

Anyway, I wasn't sure myself that merits the starter but since there are quite a few starters that pull the same amount of dependencies (or even less) and that all Spring projects Boot provides auto-configuration for do have their own starters, I've proposed this one for consistency sake.

@snicoll
Copy link
Member

snicoll commented Jul 5, 2017

With the modules split, I think it's pretty clear we won't add a starter. We've discussed this today so I am closing this, we can reopen if I missed something.

@snicoll snicoll closed this as completed Jul 5, 2017
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-votes labels Jul 5, 2017
@vpavic
Copy link
Contributor Author

vpavic commented Jul 5, 2017

Agreed - I was about to close this myself today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

4 participants