Skip to content

Consider reflection hints for generated Querydsl Q classes #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Oct 19, 2022 · 0 comments
Closed

Consider reflection hints for generated Querydsl Q classes #2721

mp911de opened this issue Oct 19, 2022 · 0 comments
Assignees
@christophstrobl
Labels
theme: aot An issue related to Ahead-Of-Time processing type: enhancement A general enhancement
Milestone
3.0.1 (2022.0.1)

Comments

@mp911de
Copy link
Member

mp911de commented Oct 19, 2022

When using Querydsl, we attempt to access generated Q classes reflectively. Without including runtime hints, reflective access fails.

It would make sense to consider how and where Q classes could be included into the final artifact.

Related to #2717
@mp911de mp911de added type: enhancement A general enhancement theme: aot An issue related to Ahead-Of-Time processing labels Oct 19, 2022
@christophstrobl christophstrobl self-assigned this Dec 2, 2022
This was referenced Dec 2, 2022
Closed
Closed
@mp911de mp911de added this to the 3.0.1 (2022.0.1) milestone Dec 12, 2022
mp911de added a commit that referenced this issue Dec 12, 2022
@mp911de
Polishing.
f8d6c9f 
Avoid caching. Expand exception handling to all reflective exceptions. Fix since tags.

See: #2721
Original pull request: #2743.
mp911de pushed a commit that referenced this issue Dec 12, 2022
@christophstrobl @mp911de
Register reflection hints for Querydsl Q types.
1566cdf 
This commit introduced support for registering GraalVM native reflection type hints for Querydsl Q types that target domain types used in the repository interface declaration.

At this point we only do a simple lookup for Q types based in the very same package that implement EntityPath.
More advanced configuration (eg. base package and type prefix), potentially available via EntityPathResolver are not taken into account as this would require eager bean resolution from the application context, which is likely to trigger additional infrastructure. In this case the user is required to register Q types manually.

Closes: #2721
Original pull request: #2743.
mp911de added a commit that referenced this issue Dec 12, 2022
@mp911de
Polishing.
10c6373 
Avoid caching. Expand exception handling to all reflective exceptions. Fix since tags.

See: #2721
Original pull request: #2743.
@christophstrobl christophstrobl mentioned this issue Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
theme: aot An issue related to Ahead-Of-Time processing type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.1 (2022.0.1)
Development

Successfully merging a pull request may close this issue.

Register reflection hints for Querydsl Q types. spring-projects/spring-data-commons
2 participants
@mp911de @christophstrobl