Skip to content

Commit 2057b12

Browse files
xhaggisothawo
andauthored
fixup! Move dynamic mapping parameter configuration to @document and @field
Co-authored-by: Peter-Josef Meisch <[email protected]>
1 parent 53c24e1 commit 2057b12

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/main/java/org/springframework/data/elasticsearch/annotations/DynamicMapping.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
* @author Peter-Josef Meisch
2929
* @author Sascha Woo
3030
* @since 4.0
31-
* @deprecated use {@link Document#dynamic()} or {@link Field#dynamic()} instead.
31+
* @deprecated since 4.3, use {@link Document#dynamic()} or {@link Field#dynamic()} instead.
3232
*/
3333
@Retention(RetentionPolicy.RUNTIME)
3434
@Target({ ElementType.TYPE, ElementType.FIELD })

src/main/java/org/springframework/data/elasticsearch/annotations/DynamicMappingValue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
* @author Peter-Josef Meisch
2222
* @author Sascha Woo
2323
* @since 4.0
24-
* @deprecated use {@link Document#dynamic()} or {@link Field#dynamic()} instead.
24+
* @deprecated since 4.3, use {@link Document#dynamic()} or {@link Field#dynamic()} instead.
2525
*/
2626
@Deprecated
2727
public enum DynamicMappingValue {

src/main/java/org/springframework/data/elasticsearch/core/mapping/SimpleElasticsearchPersistentEntity.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public class SimpleElasticsearchPersistentEntity<T> extends BasicPersistentEntit
7474
private @Nullable ElasticsearchPersistentProperty joinFieldProperty;
7575
private @Nullable VersionType versionType;
7676
private boolean createIndexAndMapping;
77-
private Dynamic dynamic = Dynamic.INHERIT;
77+
private final Dynamic dynamic = Dynamic;
7878
private final Map<String, ElasticsearchPersistentProperty> fieldNamePropertyCache = new ConcurrentHashMap<>();
7979
private final ConcurrentHashMap<String, Expression> routingExpressions = new ConcurrentHashMap<>();
8080
private @Nullable String routing;
@@ -105,8 +105,9 @@ public SimpleElasticsearchPersistentEntity(TypeInformation<T> typeInformation,
105105
this.versionType = document.versionType();
106106
this.createIndexAndMapping = document.createIndex();
107107
this.dynamic = document.dynamic();
108-
}
109-
108+
} else {
109+
this.dynamic = Dynamic.INHERIT;
110+
}
110111
Routing routingAnnotation = AnnotatedElementUtils.findMergedAnnotation(clazz, Routing.class);
111112

112113
if (routingAnnotation != null) {

0 commit comments

Comments
 (0)