DATAJPA-218 - Use true is true predicate if probe yields to empty criteria.

Author: mp911de

src/main/java/org/springframework/data/jpa/convert/QueryByExamplePredicateBuilder.java

@@ -82,7 +82,7 @@ public static <T> Predicate getPredicate(Root<T> root, CriteriaBuilder cb, Examp
 				new PathNode("root", null, example.getProbe()));
 
 		if (predicates.isEmpty()) {
-			return cb.isTrue(cb.literal(false));
+			return cb.isTrue(cb.literal(true));
 		}
 
 		if (predicates.size() == 1) {

src/main/java/org/springframework/data/jpa/provider/PersistenceProvider.java

@@ -52,7 +52,7 @@
  * @author Oliver Gierke
  * @author Thomas Darimont
  */
-public enum PersistenceProvider implements QueryExtractor, ProxyIdAccessor {
+public enum PersistenceProvider implements QueryExtractor,ProxyIdAccessor {
 
 	/**
 	 * Hibernate persistence provider.
@@ -117,14 +117,13 @@ public <T> Collection<T> potentiallyConvertEmptyCollection(Collection<T> collect
 		public CloseableIterator<Object> executeQueryWithResultStream(Query jpaQuery) {
 			return new HibernateScrollableResultsIterator<Object>(jpaQuery);
 		}
-
 	},
 
 	/**
 	 * EclipseLink persistence provider.
 	 */
-	ECLIPSELINK(Collections.singleton(ECLIPSELINK_ENTITY_MANAGER_INTERFACE), Collections
-			.singleton(ECLIPSELINK_JPA_METAMODEL_TYPE)) {
+	ECLIPSELINK(Collections.singleton(ECLIPSELINK_ENTITY_MANAGER_INTERFACE),
+			Collections.singleton(ECLIPSELINK_JPA_METAMODEL_TYPE)) {
 
 		public String extractQueryString(Query query) {
 			return ((JpaQuery<?>) query).getDatabaseQuery().getJPQLString();
@@ -164,7 +163,6 @@ public <T> Collection<T> potentiallyConvertEmptyCollection(Collection<T> collect
 		public CloseableIterator<Object> executeQueryWithResultStream(Query jpaQuery) {
 			return new EclipseLinkScrollableResultsIterator<Object>(jpaQuery);
 		}
-
 	},
 
 	/**
@@ -203,7 +201,6 @@ public Object getIdentifierFrom(Object entity) {
 		public CloseableIterator<Object> executeQueryWithResultStream(Query jpaQuery) {
 			return new OpenJpaResultStreamingIterator<Object>(jpaQuery);
 		}
-
 	},
 
 	/**
@@ -246,7 +243,6 @@ public boolean shouldUseAccessorFor(Object entity) {
 		public Object getIdentifierFrom(Object entity) {
 			return null;
 		}
-
 	};
 
 	/**
@@ -388,8 +384,8 @@ public <T> Collection<T> potentiallyConvertEmptyCollection(Collection<T> collect
 	}
 
 	public CloseableIterator<Object> executeQueryWithResultStream(Query jpaQuery) {
-		throw new UnsupportedOperationException("Streaming results is not implement for this PersistenceProvider: "
-				+ name());
+		throw new UnsupportedOperationException(
+				"Streaming results is not implement for this PersistenceProvider: " + name());
 	}
 
 	/**

src/main/java/org/springframework/data/jpa/repository/JpaRepository.java

@@ -41,28 +41,24 @@ public interface JpaRepository<T, ID extends Serializable>
 	 * (non-Javadoc)
 	 * @see org.springframework.data.repository.CrudRepository#findAll()
 	 */
-	@Override
 	List<T> findAll();
 
 	/*
 	 * (non-Javadoc)
 	 * @see org.springframework.data.repository.PagingAndSortingRepository#findAll(org.springframework.data.domain.Sort)
 	 */
-	@Override
 	List<T> findAll(Sort sort);
 
 	/*
 	 * (non-Javadoc)
 	 * @see org.springframework.data.repository.CrudRepository#findAll(java.lang.Iterable)
 	 */
-	@Override
 	List<T> findAll(Iterable<ID> ids);
 
 	/*
 	 * (non-Javadoc)
 	 * @see org.springframework.data.repository.CrudRepository#save(java.lang.Iterable)
 	 */
-	@Override
 	<S extends T> List<S> save(Iterable<S> entities);
 
 	/**
@@ -72,7 +68,7 @@ public interface JpaRepository<T, ID extends Serializable>
 
 	/**
 	 * Saves an entity and flushes changes instantly.
-	 *
+	 * 
 	 * @param entity
 	 * @return the saved entity
 	 */
@@ -81,7 +77,7 @@ public interface JpaRepository<T, ID extends Serializable>
 	/**
 	 * Deletes the given entities in a batch which means it will create a single {@link Query}. Assume that we will clear
 	 * the {@link javax.persistence.EntityManager} after the call.
-	 *
+	 * 
 	 * @param entities
 	 */
 	void deleteInBatch(Iterable<T> entities);
@@ -93,7 +89,7 @@ public interface JpaRepository<T, ID extends Serializable>
 
 	/**
 	 * Returns a reference to the entity with the given identifier.
-	 *
+	 * 
 	 * @param id must not be {@literal null}.
 	 * @return a reference to the entity with the given identifier.
 	 * @see EntityManager#getReference(Class, Object)

src/main/java/org/springframework/data/jpa/repository/query/AbstractJpaQuery.java

@@ -189,8 +189,8 @@ private Query applyEntityGraphConfiguration(Query query, JpaQueryMethod method)
 		Assert.notNull(query, "Query must not be null!");
 		Assert.notNull(method, "JpaQueryMethod must not be null!");
 
-		Map<String, Object> hints = Jpa21Utils.tryGetFetchGraphHints(em, method.getEntityGraph(), getQueryMethod()
-				.getEntityInformation().getJavaType());
+		Map<String, Object> hints = Jpa21Utils.tryGetFetchGraphHints(em, method.getEntityGraph(),
+				getQueryMethod().getEntityInformation().getJavaType());
 
 		for (Map.Entry<String, Object> hint : hints.entrySet()) {
 			query.setHint(hint.getKey(), hint.getValue());