Fix positional binding when only later positions are reported#4170
Closed
hgwr wants to merge 1 commit intospring-projects:mainfrom
Closed
Fix positional binding when only later positions are reported#4170hgwr wants to merge 1 commit intospring-projects:mainfrom
hgwr wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: Shigeru Hagiwara <shigeru.hagiwara@ofaas.jp>
hgwr
force-pushed
the
fix-el-positional-underreport
branch
from
cfad1d4 to
238d679
Compare
mp911de
added
type: bug
Member
|
The problem is that the parameter binding index is being incremented leading to gaps in numbering and that is the actual problem to be fixed. Closing in favor of 747a3ee. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix binding for EclipseLink when a derived query collapses to
... IS NULL AND ... = ?2and the provider reports only position 2. We now bind positional parameters based on the reported positions (falling back to the previous size heuristic when no positional metadata is available).This prevents
Query argument 2 not foundseen in #4167. Reproducer and logs: #4167 (comment).Tests: ./mvnw -pl spring-data-jpa -Dtest=NamedOrIndexedQueryParameterSetterUnitTests test (local
eclipselink-testfork still fails due to the existing EclipseLink javaagent ASM error).