Skip to content

Commit 73a0f04

Browse files
christophstroblmp911de
authored andcommitted
Polishing.
Fix typo in class name and make sure MongoTestTemplate uses the configured simple types. Remove superfluous junit extension. See: #3659 Original pull request: #3661.
1 parent a1c1659 commit 73a0f04

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java

+1
Original file line numberDiff line numberDiff line change
@@ -1228,6 +1228,7 @@ private PersistentPropertyPath<MongoPersistentProperty> getPath(String pathExpre
12281228
return propertyPath;
12291229
}
12301230

1231+
@Nullable
12311232
private PersistentPropertyPath<MongoPersistentProperty> tryToResolvePersistentPropertyPath(PropertyPath path) {
12321233

12331234
try {

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/QueryMapperUnitTests.java

+3-7
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import java.util.Map;
2929
import java.util.Optional;
3030

31-
import lombok.Data;
3231
import org.bson.conversions.Bson;
3332
import org.bson.types.Code;
3433
import org.bson.types.ObjectId;
@@ -49,12 +48,10 @@
4948
import org.springframework.data.mongodb.core.geo.GeoJsonPolygon;
5049
import org.springframework.data.mongodb.core.mapping.DBRef;
5150
import org.springframework.data.mongodb.core.mapping.Document;
52-
import org.springframework.data.mongodb.core.mapping.DocumentReference;
5351
import org.springframework.data.mongodb.core.mapping.Field;
5452
import org.springframework.data.mongodb.core.mapping.FieldType;
5553
import org.springframework.data.mongodb.core.mapping.MongoMappingContext;
5654
import org.springframework.data.mongodb.core.mapping.MongoPersistentEntity;
57-
import org.springframework.data.mongodb.core.mapping.MongoPersistentProperty;
5855
import org.springframework.data.mongodb.core.mapping.TextScore;
5956
import org.springframework.data.mongodb.core.mapping.Unwrapped;
6057
import org.springframework.data.mongodb.core.query.BasicQuery;
@@ -75,7 +72,6 @@
7572
* @author Christoph Strobl
7673
* @author Mark Paluch
7774
*/
78-
@ExtendWith(MockitoExtension.class)
7975
public class QueryMapperUnitTests {
8076

8177
private QueryMapper mapper;
@@ -1447,18 +1443,18 @@ static class ClassWithGeoTypes {
14471443
@Field("geoJsonPointWithNameViaFieldAnnotation") GeoJsonPoint namedGeoJsonPoint;
14481444
}
14491445

1450-
static class SimpeEntityWithoutId {
1446+
static class SimpleEntityWithoutId {
14511447

14521448
String stringProperty;
14531449
Integer integerProperty;
14541450
}
14551451

14561452
static class EntityWithComplexValueTypeMap {
1457-
Map<Integer, SimpeEntityWithoutId> map;
1453+
Map<Integer, SimpleEntityWithoutId> map;
14581454
}
14591455

14601456
static class EntityWithComplexValueTypeList {
1461-
List<SimpeEntityWithoutId> list;
1457+
List<SimpleEntityWithoutId> list;
14621458
}
14631459

14641460
static class WithExplicitTargetTypes {

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/test/util/MongoTestTemplateConfiguration.java

+3
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,9 @@ MongoMappingContext mappingContext() {
119119
mappingContext = new MongoMappingContext();
120120
mappingContext.setInitialEntitySet(mappingContextConfigurer.initialEntitySet());
121121
mappingContext.setAutoIndexCreation(mappingContextConfigurer.autocreateIndex);
122+
if(mongoConverterConfigurer.customConversions != null) {
123+
mappingContext.setSimpleTypeHolder(mongoConverterConfigurer.customConversions.getSimpleTypeHolder());
124+
}
122125
mappingContext.afterPropertiesSet();
123126
}
124127

0 commit comments

Comments
 (0)