Skip to content

Commit d6c812a

Browse files
committed
#104 - Incorporate review feedback.
Original pull request: #127.
1 parent 9f6cf40 commit d6c812a

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

src/main/java/org/springframework/data/r2dbc/dialect/DialectResolver.java

+6-9
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
import org.springframework.core.io.support.SpringFactoriesLoader;
2727
import org.springframework.dao.NonTransientDataAccessException;
28+
import org.springframework.data.util.Optionals;
2829
import org.springframework.util.LinkedCaseInsensitiveMap;
2930

3031
/**
@@ -55,9 +56,8 @@ public static R2dbcDialect getDialect(ConnectionFactory connectionFactory) {
5556

5657
return DETECTORS.stream() //
5758
.map(it -> it.getDialect(connectionFactory)) //
58-
.filter(Optional::isPresent) //
59+
.flatMap(Optionals::toStream) //
5960
.findFirst() //
60-
.flatMap(it -> it) //
6161
.orElseThrow(() -> {
6262
return new NoDialectException(
6363
String.format("Cannot determine a dialect for %s using %s. Please provide a Dialect.",
@@ -127,13 +127,10 @@ public Optional<R2dbcDialect> getDialect(ConnectionFactory connectionFactory) {
127127
return Optional.of(r2dbcDialect);
128128
}
129129

130-
for (String key : BUILTIN.keySet()) {
131-
if (metadata.getName().contains(key)) {
132-
return Optional.of(BUILTIN.get(key));
133-
}
134-
}
135-
136-
return Optional.empty();
130+
return BUILTIN.keySet().stream() //
131+
.filter(it -> metadata.getName().contains(it)) //
132+
.map(BUILTIN::get) //
133+
.findFirst();
137134
}
138135
}
139136
}

0 commit comments

Comments
 (0)