Skip to content

WebClient Observation does not propagate context #29339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcingrzejszczak opened this issue Oct 18, 2022 · 1 comment
Closed

WebClient Observation does not propagate context #29339

marcingrzejszczak opened this issue Oct 18, 2022 · 1 comment
Assignees
@bclozel
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another theme: observability An issue related to observability and tracing type: bug A general bug

Comments

@marcingrzejszczak
Copy link
Contributor

currently the DefaultWebClient is first starting the observation and only after we start it do we set the carrier on the context. That leads to not setting any trace related headers on the carrier (because there's no carrier at the start of the Observation).

Also, we should be checking whether there's a parent observation in the Reactor Context before we start the observation for the WebClient call
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 18, 2022
@bclozel bclozel self-assigned this Oct 18, 2022
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug theme: observability An issue related to observability and tracing and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 18, 2022
@bclozel bclozel modified the milestones: 6.0.0, 6.0.0-RC2 Oct 19, 2022
@jhoeller jhoeller modified the milestones: 6.0.0, 6.0.0-RC3 Oct 20, 2022
@marcingrzejszczak marcingrzejszczak mentioned this issue Oct 27, 2022
Closed
@sbrannen sbrannen changed the title WebClient Observation not propagating context WebClient Observation does not propagate context Nov 1, 2022
@bclozel bclozel removed this from the 6.0.0-RC3 milestone Nov 2, 2022
@bclozel bclozel added the status: declined A suggestion or change that we don't feel we should currently apply label Nov 2, 2022
@bclozel
Copy link
Member

bclozel commented Nov 2, 2022

Closing in favor of #29388.

@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
@bclozel bclozel added status: superseded An issue that has been superseded by another and removed status: declined A suggestion or change that we don't feel we should currently apply labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another theme: observability An issue related to observability and tracing type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WebClient and WebFlux Observation do not propagate context marcingrzejszczak/spring-framework
4 participants
@bclozel @jhoeller @marcingrzejszczak @spring-projects-issues