Skip to content

Support repeatable writes in FormHttpMessageConverter#writeMultipart #34859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NicklasWallgren opened this issue May 7, 2025 · 1 comment
Open

Support repeatable writes in FormHttpMessageConverter#writeMultipart #34859

NicklasWallgren opened this issue May 7, 2025 · 1 comment
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
7.0.0-M7

Comments

@NicklasWallgren
Copy link

NicklasWallgren commented May 7, 2025 •
edited
Loading

The FormHttpMessageConverter#writeMultipart method should support repeatable bodies, rather than only supporting single-write. Today StreamingHttpOutputMessage.Body#repeatable returns false, by default.

FormHttpMessageConverter#writeForm got support for repeatable writes in
6dd93d4

Continuation of #31449 (comment)
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 7, 2025
@bclozel bclozel added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Jun 3, 2025
@rstoyanchev
Copy link
Contributor

Some parts may not be repeatable. To find out for sure, it is necessary to iterate parts upfront, find a compatible message converter for each part, and check with the converter if the given (part) object is repeatable. If all parts are repeatable, then the multipart write is repeatable.

@rstoyanchev rstoyanchev changed the title Allow repeatable writes in FormHttpMessageConverter#writeMultipart Support repeatable writes in FormHttpMessageConverter#writeMultipart Jun 10, 2025
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 10, 2025
@rstoyanchev rstoyanchev self-assigned this Jun 10, 2025
@rstoyanchev rstoyanchev modified the milestones: 7.0.0-M6, 7.0.x, 7.0.0-M7 Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M7
Development

No branches or pull requests
4 participants
@bclozel @rstoyanchev @NicklasWallgren @spring-projects-issues