Skip to content

Commit 4ab7c39

Browse files
jdpgrailsdevartembilan
authored andcommitted
Handle possible null management overrides
1 parent 57d4584 commit 4ab7c39

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

spring-integration-core/src/main/java/org/springframework/integration/config/IntegrationManagementConfigurer.java

+10-5
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
* @author Gary Russell
5555
* @author Artem Bilan
5656
* @author Meherzad Lahewala
57+
* @author Jonathan Pearlin
5758
*
5859
* @since 4.2
5960
*
@@ -278,7 +279,7 @@ public void afterSingletonsInstantiated() {
278279
.getBeansOfType(IntegrationManagement.class);
279280
for (Entry<String, IntegrationManagement> entry : managed.entrySet()) {
280281
IntegrationManagement bean = entry.getValue();
281-
if (!bean.getOverrides().loggingConfigured) {
282+
if (!getOverrides(bean).loggingConfigured) {
282283
bean.setLoggingEnabled(this.defaultLoggingEnabled);
283284
}
284285
String name = entry.getKey();
@@ -292,7 +293,7 @@ private void injectCaptor() {
292293
.getBeansOfType(IntegrationManagement.class);
293294
for (Entry<String, IntegrationManagement> entry : managed.entrySet()) {
294295
IntegrationManagement bean = entry.getValue();
295-
if (!bean.getOverrides().loggingConfigured) {
296+
if (!getOverrides(bean).loggingConfigured) {
296297
bean.setLoggingEnabled(this.defaultLoggingEnabled);
297298
}
298299
bean.registerMetricsCaptor(this.metricsCaptor);
@@ -364,7 +365,7 @@ private void configureChannelMetrics(String name,
364365
metrics = this.metricsFactory.createChannelMetrics(name);
365366
}
366367
Assert.state(metrics != null, "'metrics' must not be null");
367-
ManagementOverrides overrides = bean.getOverrides();
368+
ManagementOverrides overrides = getOverrides(bean);
368369
Boolean enabled = PatternMatchUtils.smartMatch(name, this.enabledCountsPatterns);
369370
if (enabled != null) {
370371
bean.setCountsEnabled(enabled);
@@ -396,7 +397,7 @@ private void configureHandlerMetrics(String name,
396397
org.springframework.integration.support.management.MessageHandlerMetrics bean) {
397398
AbstractMessageHandlerMetrics metrics = this.metricsFactory.createHandlerMetrics(name);
398399
Assert.state(metrics != null, "'metrics' must not be null");
399-
ManagementOverrides overrides = bean.getOverrides();
400+
ManagementOverrides overrides = getOverrides(bean);
400401
Boolean enabled = PatternMatchUtils.smartMatch(name, this.enabledCountsPatterns);
401402
if (enabled != null) {
402403
bean.setCountsEnabled(enabled);
@@ -432,7 +433,7 @@ private void configureSourceMetrics(String name,
432433
bean.setCountsEnabled(enabled);
433434
}
434435
else {
435-
if (!bean.getOverrides().countsConfigured) {
436+
if (!getOverrides(bean).countsConfigured) {
436437
bean.setCountsEnabled(this.defaultCountsEnabled);
437438
}
438439
}
@@ -506,4 +507,8 @@ public org.springframework.integration.support.management.MessageSourceMetrics g
506507
return null;
507508
}
508509

510+
private static ManagementOverrides getOverrides(IntegrationManagement bean) {
511+
return bean.getOverrides() != null ? bean.getOverrides() : new ManagementOverrides();
512+
}
513+
509514
}

0 commit comments

Comments
 (0)