Skip to content

Commit cb53861

Browse files
garyrussellartembilan
authored andcommitted
GH-2874: Syslog - copy IpHeaders to message
Resolves #2874 **cherry-pick to 5.1.x**
1 parent d2853be commit cb53861

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

spring-integration-syslog/src/main/java/org/springframework/integration/syslog/DefaultMessageConverter.java

+1
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ public Message<?> fromSyslog(Message<?> message) {
9393
}
9494
}
9595
return getMessageBuilderFactory().withPayload(this.asMap ? map : message.getPayload())
96+
.copyHeaders(message.getHeaders())
9697
.copyHeaders(out)
9798
.build();
9899
}

spring-integration-syslog/src/main/java/org/springframework/integration/syslog/RFC5424MessageConverter.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ public Message<?> fromSyslog(Message<?> message) {
8585
}
8686

8787
AbstractIntegrationMessageBuilder<Object> builder = getMessageBuilderFactory().withPayload(
88-
asMap() ? map : originalContent);
88+
asMap() ? map : originalContent)
89+
.copyHeaders(message.getHeaders());
8990
if (!asMap() && isMap) {
9091
builder.copyHeaders(map);
9192
}

spring-integration-syslog/src/test/java/org/springframework/integration/syslog/inbound/SyslogReceivingChannelAdapterTests.java

+6
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
import org.springframework.context.ApplicationEvent;
4343
import org.springframework.context.ApplicationEventPublisher;
4444
import org.springframework.integration.channel.QueueChannel;
45+
import org.springframework.integration.ip.IpHeaders;
4546
import org.springframework.integration.ip.tcp.connection.AbstractServerConnectionFactory;
4647
import org.springframework.integration.ip.tcp.connection.TcpNioServerConnectionFactory;
4748
import org.springframework.integration.ip.udp.UnicastReceivingChannelAdapter;
@@ -84,6 +85,7 @@ public void testUdp() throws Exception {
8485
Message<?> message = outputChannel.receive(10000);
8586
assertThat(message).isNotNull();
8687
assertThat(message.getHeaders().get("syslog_HOST")).isEqualTo("WEBERN");
88+
assertThat(message.getHeaders().get(IpHeaders.IP_ADDRESS)).isNotNull();
8789
adapter.stop();
8890
}
8991

@@ -128,6 +130,7 @@ public void testTcp() throws Exception {
128130
Message<?> message = outputChannel.receive(10000);
129131
assertThat(message).isNotNull();
130132
assertThat(message.getHeaders().get("syslog_HOST")).isEqualTo("WEBERN");
133+
assertThat(message.getHeaders().get(IpHeaders.IP_ADDRESS)).isNotNull();
131134
adapter.stop();
132135
assertThat(latch.await(10, TimeUnit.SECONDS)).isTrue();
133136
}
@@ -161,6 +164,7 @@ public void testAsMapFalse() throws Exception {
161164
assertThat(message.getHeaders().get("syslog_HOST")).isEqualTo("WEBERN");
162165
assertThat(new String((byte[]) message.getPayload(), "UTF-8"))
163166
.isEqualTo("<157>JUL 26 22:08:35 WEBERN TESTING[70729]: TEST SYSLOG MESSAGE");
167+
assertThat(message.getHeaders().get(IpHeaders.IP_ADDRESS)).isNotNull();
164168
adapter.stop();
165169
}
166170

@@ -210,6 +214,7 @@ public void testTcpRFC5424() throws Exception {
210214
Message<Map<String, ?>> message = (Message<Map<String, ?>>) outputChannel.receive(10000);
211215
assertThat(message).isNotNull();
212216
assertThat(message.getPayload().get("syslog_HOST")).isEqualTo("loggregator");
217+
assertThat(message.getHeaders().get(IpHeaders.IP_ADDRESS)).isNotNull();
213218
adapter.stop();
214219
assertThat(latch.await(10, TimeUnit.SECONDS)).isTrue();
215220
}
@@ -243,6 +248,7 @@ public void testUdpRFC5424() throws Exception {
243248
Message<Map<String, ?>> message = (Message<Map<String, ?>>) outputChannel.receive(10000);
244249
assertThat(message).isNotNull();
245250
assertThat(message.getPayload().get("syslog_HOST")).isEqualTo("loggregator");
251+
assertThat(message.getHeaders().get(IpHeaders.IP_ADDRESS)).isNotNull();
246252
adapter.stop();
247253
}
248254

0 commit comments

Comments
 (0)