Skip to content

Commit dc88bb4

Browse files
committed
Drop H2 schema before JDBC tests
https://build.spring.io/browse/INT-MJATS41-1679/ **Cherry-pick to 5.1.x & 5.0.x**
1 parent 8aef55f commit dc88bb4

File tree

3 files changed

+15
-9
lines changed

3 files changed

+15
-9
lines changed

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/leader/JdbcLockRegistryLeaderInitiatorTests.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ public class JdbcLockRegistryLeaderInitiatorTests {
5252
public static void init() {
5353
dataSource = new EmbeddedDatabaseBuilder()
5454
.setType(EmbeddedDatabaseType.H2)
55+
.addScript("classpath:/org/springframework/integration/jdbc/schema-drop-h2.sql")
5556
.addScript("classpath:/org/springframework/integration/jdbc/schema-h2.sql")
5657
.build();
5758
}
@@ -65,7 +66,7 @@ public static void destroy() {
6566
public void testDistributedLeaderElection() throws Exception {
6667
CountDownLatch granted = new CountDownLatch(1);
6768
CountingPublisher countingPublisher = new CountingPublisher(granted);
68-
List<LockRegistryLeaderInitiator> initiators = new ArrayList<LockRegistryLeaderInitiator>();
69+
List<LockRegistryLeaderInitiator> initiators = new ArrayList<>();
6970
for (int i = 0; i < 2; i++) {
7071
DefaultLockRepository lockRepository = new DefaultLockRepository(dataSource);
7172
lockRepository.afterPropertiesSet();

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/store/JdbcMessageStoreChannelTests-context.xml

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<jdbc:embedded-database id="dataSource" type="H2" />
1414

1515
<jdbc:initialize-database data-source="dataSource">
16+
<jdbc:script location="org/springframework/integration/jdbc/schema-drop-h2.sql"/>
1617
<jdbc:script location="org/springframework/integration/jdbc/schema-h2.sql" />
1718
</jdbc:initialize-database>
1819

spring-integration-jdbc/src/test/java/org/springframework/integration/jdbc/store/JdbcMessageStoreRegionTests.java

+12-8
Original file line numberDiff line numberDiff line change
@@ -29,26 +29,29 @@
2929

3030
import org.springframework.integration.support.MessageBuilder;
3131
import org.springframework.jdbc.core.JdbcTemplate;
32-
import org.springframework.jdbc.core.RowMapper;
3332
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabase;
3433
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseBuilder;
3534
import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseType;
3635

3736
/**
3837
* @author Gunnar Hillert
38+
* @author Artem Bilan
3939
*/
4040
public class JdbcMessageStoreRegionTests {
4141

4242
private static EmbeddedDatabase dataSource;
43+
4344
private JdbcTemplate jdbcTemplate;
4445

4546
private JdbcMessageStore messageStore1;
47+
4648
private JdbcMessageStore messageStore2;
4749

4850
@BeforeClass
4951
public static void setupDatabase() {
5052
dataSource = new EmbeddedDatabaseBuilder()
5153
.setType(EmbeddedDatabaseType.H2)
54+
.addScript("classpath:/org/springframework/integration/jdbc/schema-drop-h2.sql")
5255
.addScript("classpath:/org/springframework/integration/jdbc/schema-h2.sql")
5356
.build();
5457
}
@@ -76,7 +79,7 @@ public void afterTest() {
7679
}
7780

7881
@Test
79-
public void testVerifyMessageCount() throws Exception {
82+
public void testVerifyMessageCount() {
8083

8184
messageStore1.addMessage(MessageBuilder.withPayload("payload1").build());
8285
messageStore1.addMessage(MessageBuilder.withPayload("payload2").build());
@@ -90,7 +93,7 @@ public void testVerifyMessageCount() throws Exception {
9093
}
9194

9295
@Test
93-
public void testInsertNullRegion() throws Exception {
96+
public void testInsertNullRegion() {
9497

9598
try {
9699
messageStore1.setRegion(null);
@@ -104,7 +107,7 @@ public void testInsertNullRegion() throws Exception {
104107
}
105108

106109
@Test
107-
public void testVerifyMessageGroupCount() throws Exception {
110+
public void testVerifyMessageGroupCount() {
108111

109112
messageStore1.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
110113
messageStore1.addMessageToGroup("group2", MessageBuilder.withPayload("payload2").build());
@@ -123,28 +126,28 @@ public void testVerifyMessageGroupCount() throws Exception {
123126
}
124127

125128
@Test
126-
public void testRegionSetToMessageGroup() throws Exception {
129+
public void testRegionSetToMessageGroup() {
127130

128131
messageStore1.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
129132

130133
List<String> regions = jdbcTemplate.query("Select * from INT_MESSAGE_GROUP where REGION = 'region1'",
131-
(RowMapper<String>) (rs, rowNum) -> rs.getString("REGION"));
134+
(rs, rowNum) -> rs.getString("REGION"));
132135

133136
assertThat(regions.size()).isEqualTo(1);
134137
assertThat(regions.get(0)).isEqualTo("region1");
135138

136139
messageStore2.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
137140

138141
List<String> regions2 = jdbcTemplate.query("Select * from INT_MESSAGE_GROUP where REGION = 'region2'",
139-
(RowMapper<String>) (rs, rowNum) -> rs.getString("REGION"));
142+
(rs, rowNum) -> rs.getString("REGION"));
140143

141144
assertThat(regions2.size()).isEqualTo(1);
142145
assertThat(regions2.get(0)).isEqualTo("region2");
143146

144147
}
145148

146149
@Test
147-
public void testRemoveMessageGroup() throws Exception {
150+
public void testRemoveMessageGroup() {
148151

149152
messageStore1.addMessageToGroup("group1", MessageBuilder.withPayload("payload1").build());
150153
messageStore1.addMessageToGroup("group2", MessageBuilder.withPayload("payload2").build());
@@ -158,4 +161,5 @@ public void testRemoveMessageGroup() throws Exception {
158161
assertThat(messageStore2.getMessageGroupCount()).isEqualTo(2);
159162

160163
}
164+
161165
}

0 commit comments

Comments
 (0)