Skip to content

Commit e50a0f5

Browse files
committed
Fix HttpProxyScenarioTests for proper date format
https://build.spring.io/browse/INT-MASTERSPRING40-663/ https://build.spring.io/browse/INT-FATS5IC-832/ **Cherry-pick to 5.1.x & 5.0.x** * Upgrade dependencies; prepare for release
1 parent 89cf135 commit e50a0f5

File tree

2 files changed

+29
-28
lines changed

2 files changed

+29
-28
lines changed

build.gradle

+21-21
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ buildscript {
1111
}
1212

1313
plugins {
14-
id 'org.sonarqube' version '2.6.2'
14+
id 'org.sonarqube' version '2.7'
1515
id 'org.asciidoctor.convert' version '1.5.9.2'
1616
id 'org.ajoberstar.grgit' version '3.0.0'
1717
}
@@ -88,26 +88,26 @@ subprojects { subproject ->
8888

8989
ext {
9090
activeMqVersion = '5.15.9'
91-
apacheSshdVersion = '2.1.0'
91+
apacheSshdVersion = '2.2.0'
9292
aspectjVersion = '1.9.2'
93-
assertjVersion = '3.11.1'
93+
assertjVersion = '3.12.2'
9494
assertkVersion = '0.13'
9595
boonVersion = '0.34'
9696
commonsDbcp2Version = '2.5.0'
9797
commonsIoVersion = '2.6'
9898
commonsNetVersion = '3.6'
9999
curatorVersion = '4.0.1'
100-
derbyVersion = '10.14.2.0'
101-
eclipseLinkVersion = '2.7.3'
100+
derbyVersion = '10.15.1.3'
101+
eclipseLinkVersion = '2.7.4'
102102
ftpServerVersion = '1.1.1'
103103
googleJsr305Version = '3.0.2'
104104
groovyVersion = '2.5.6'
105105
guavaVersion = '26.0-jre'
106106
hamcrestVersion = '1.3'
107-
hazelcastVersion = '3.11.1'
108-
hibernateVersion = '5.4.1.Final'
107+
hazelcastVersion = '3.11.2'
108+
hibernateVersion = '5.4.2.Final'
109109
hsqldbVersion = '2.4.1'
110-
h2Version = '1.4.197'
110+
h2Version = '1.4.199'
111111
jackson2Version = '2.9.8'
112112
javaxActivationVersion = '1.1.1'
113113
javaxMailVersion = '1.6.2'
@@ -118,32 +118,32 @@ subprojects { subproject ->
118118
jschVersion = '0.1.55'
119119
jsonpathVersion = '2.4.0'
120120
junit4Version = '4.12'
121-
junitJupiterVersion = '5.4.0'
122-
junitPlatformVersion = '1.4.0'
121+
junitJupiterVersion = '5.4.1'
122+
junitPlatformVersion = '1.4.1'
123123
jythonVersion = '2.7.0'
124124
kryoShadedVersion = '4.0.2'
125125
lettuceVersion = '5.1.6.RELEASE'
126126
log4jVersion = '2.11.2'
127127
micrometerVersion = '1.1.3'
128-
mockitoVersion = '2.24.0'
128+
mockitoVersion = '2.25.1'
129129
mysqlVersion = '8.0.15'
130130
pahoMqttClientVersion = '1.2.0'
131131
postgresVersion = '42.2.5'
132-
reactorNettyVersion = '0.8.5.RELEASE'
133-
reactorVersion = '3.2.6.RELEASE'
132+
reactorNettyVersion = '0.8.6.RELEASE'
133+
reactorVersion = '3.2.8.RELEASE'
134134
romeToolsVersion = '1.9.0'
135135
servletApiVersion = '4.0.0'
136-
smackVersion = '4.3.1'
137-
springAmqpVersion = project.hasProperty('springAmqpVersion') ? project.springAmqpVersion : '2.1.5.BUILD-SNAPSHOT'
138-
springDataJpaVersion = '2.1.5.RELEASE'
139-
springDataMongoVersion = '2.1.5.RELEASE'
140-
springDataRedisVersion = '2.1.5.RELEASE'
141-
springGemfireVersion = '2.1.5.RELEASE'
136+
smackVersion = '4.3.3'
137+
springAmqpVersion = project.hasProperty('springAmqpVersion') ? project.springAmqpVersion : '2.1.5.RELEASE'
138+
springDataJpaVersion = '2.1.6.RELEASE'
139+
springDataMongoVersion = '2.1.6.RELEASE'
140+
springDataRedisVersion = '2.1.6.RELEASE'
141+
springGemfireVersion = '2.1.6.RELEASE'
142142
springSecurityVersion = '5.1.4.RELEASE'
143143
springRetryVersion = '1.2.4.RELEASE'
144-
springVersion = project.hasProperty('springVersion') ? project.springVersion : '5.1.6.BUILD-SNAPSHOT'
144+
springVersion = project.hasProperty('springVersion') ? project.springVersion : '5.1.6.RELEASE'
145145
springWsVersion = '3.0.7.RELEASE'
146-
tomcatVersion = "9.0.16"
146+
tomcatVersion = "9.0.17"
147147
xstreamVersion = '1.4.11.1'
148148
}
149149

spring-integration-http/src/test/java/org/springframework/integration/http/HttpProxyScenarioTests.java

+8-7
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import java.time.ZonedDateTime;
2929
import java.time.format.DateTimeFormatter;
3030
import java.util.Calendar;
31+
import java.util.Locale;
3132

3233
import org.junit.Test;
3334
import org.junit.runner.RunWith;
@@ -49,8 +50,7 @@
4950
import org.springframework.mock.web.MockHttpServletRequest;
5051
import org.springframework.mock.web.MockHttpServletResponse;
5152
import org.springframework.test.annotation.DirtiesContext;
52-
import org.springframework.test.context.ContextConfiguration;
53-
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
53+
import org.springframework.test.context.junit4.SpringRunner;
5454
import org.springframework.util.LinkedMultiValueMap;
5555
import org.springframework.util.MultiValueMap;
5656
import org.springframework.web.client.RestTemplate;
@@ -64,10 +64,10 @@
6464
/**
6565
* @author Artem Bilan
6666
* @author Gary Russell
67+
*
6768
* @since 3.0
6869
*/
69-
@ContextConfiguration
70-
@RunWith(SpringJUnit4ClassRunner.class)
70+
@RunWith(SpringRunner.class)
7171
@DirtiesContext
7272
public class HttpProxyScenarioTests {
7373

@@ -89,8 +89,9 @@ public class HttpProxyScenarioTests {
8989

9090
@Test
9191
public void testHttpProxyScenario() throws Exception {
92-
DateTimeFormatter dateTimeFormatter = DateTimeFormatter.RFC_1123_DATE_TIME;
9392
ZoneId GMT = ZoneId.of("GMT");
93+
DateTimeFormatter dateTimeFormatter =
94+
DateTimeFormatter.ofPattern("EEE, dd MMM yyyy HH:mm:ss zzz", Locale.US).withZone(GMT);
9495

9596
Calendar c = Calendar.getInstance();
9697
c.set(Calendar.MILLISECOND, 0);
@@ -132,7 +133,7 @@ public void testHttpProxyScenario() throws Exception {
132133
assertEquals(ifUnmodifiedSinceValue, httpHeaders.getFirst("If-Unmodified-Since"));
133134
assertEquals("Keep-Alive", httpHeaders.getFirst("Connection"));
134135

135-
MultiValueMap<String, String> responseHeaders = new LinkedMultiValueMap<String, String>(httpHeaders);
136+
MultiValueMap<String, String> responseHeaders = new LinkedMultiValueMap<>(httpHeaders);
136137
responseHeaders.set("Connection", "close");
137138
responseHeaders.set("Content-Disposition", contentDispositionValue);
138139
return new ResponseEntity<>(responseHeaders, HttpStatus.OK);
@@ -189,7 +190,7 @@ public void testHttpMultipartProxyScenario() throws Exception {
189190
assertThat(entity.getBody(), instanceOf(byte[].class));
190191
assertEquals("foo", new String((byte[]) entity.getBody()));
191192

192-
MultiValueMap<String, String> responseHeaders = new LinkedMultiValueMap<String, String>(httpHeaders);
193+
MultiValueMap<String, String> responseHeaders = new LinkedMultiValueMap<>(httpHeaders);
193194
responseHeaders.set("Connection", "close");
194195
responseHeaders.set("Content-Type", "text/plain");
195196
return new ResponseEntity<Object>(responseHeaders, HttpStatus.OK);

0 commit comments

Comments
 (0)