Skip to content

Commit 8f1c20a

Browse files
committed
review fix
* rename `HandlerMethodDetect` to `AsyncRepliesAware` * fix javadoc in `ContinuationHandlerMethodArgumentResolver`
1 parent 4cd372b commit 8f1c20a

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

spring-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@
104104
import org.springframework.kafka.listener.ContainerProperties.AckMode;
105105
import org.springframework.kafka.listener.ContainerProperties.AssignmentCommitOption;
106106
import org.springframework.kafka.listener.ContainerProperties.EOSMode;
107-
import org.springframework.kafka.listener.adapter.HandlerMethodDetect;
107+
import org.springframework.kafka.listener.adapter.AsyncRepliesAware;
108108
import org.springframework.kafka.support.Acknowledgment;
109109
import org.springframework.kafka.support.KafkaHeaders;
110110
import org.springframework.kafka.support.KafkaUtils;
@@ -854,7 +854,7 @@ private final class ListenerConsumer implements SchedulingAwareRunnable, Consume
854854
ListenerConsumer(GenericMessageListener<?> listener, ListenerType listenerType,
855855
ObservationRegistry observationRegistry) {
856856

857-
this.asyncReplies = listener instanceof HandlerMethodDetect hmd && hmd.isAsyncReplies()
857+
this.asyncReplies = listener instanceof AsyncRepliesAware hmd && hmd.isAsyncReplies()
858858
|| this.containerProperties.isAsyncAcks();
859859
AckMode ackMode = determineAckMode();
860860
this.isManualAck = ackMode.equals(AckMode.MANUAL);

spring-kafka/src/main/java/org/springframework/kafka/listener/adapter/HandlerMethodDetect.java renamed to spring-kafka/src/main/java/org/springframework/kafka/listener/adapter/AsyncRepliesAware.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
package org.springframework.kafka.listener.adapter;
1818

1919
/**
20-
* Auto-detect {@link HandlerAdapter} args and return type.
20+
* Auto-detect {@link HandlerAdapter} return type.
2121
*
2222
* @author Wang zhiyang
2323
* @since 3.2
2424
*/
25-
public interface HandlerMethodDetect {
25+
public interface AsyncRepliesAware {
2626

2727
/**
2828
* Return true if this listener is request/reply and the replies are async.

spring-kafka/src/main/java/org/springframework/kafka/listener/adapter/ContinuationHandlerMethodArgumentResolver.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@
1616

1717
package org.springframework.kafka.listener.adapter;
1818

19+
import org.springframework.core.MethodParameter;
20+
import org.springframework.messaging.Message;
21+
import org.springframework.messaging.handler.invocation.HandlerMethodArgumentResolver;
22+
23+
import reactor.core.publisher.Mono;
24+
1925
/**
2026
* No-op resolver for method arguments of type {@link kotlin.coroutines.Continuation}.
2127
* <p>
@@ -24,17 +30,9 @@
2430
* but for regular {@link HandlerMethodArgumentResolver} contract.
2531
*
2632
* @author Wang Zhiyang
27-
*
2833
* @since 3.2
29-
*
3034
* @see org.springframework.messaging.handler.annotation.reactive.ContinuationHandlerMethodArgumentResolver
3135
*/
32-
import org.springframework.core.MethodParameter;
33-
import org.springframework.messaging.Message;
34-
import org.springframework.messaging.handler.invocation.HandlerMethodArgumentResolver;
35-
36-
import reactor.core.publisher.Mono;
37-
3836
public class ContinuationHandlerMethodArgumentResolver implements HandlerMethodArgumentResolver {
3937

4038
@Override

spring-kafka/src/main/java/org/springframework/kafka/listener/adapter/MessagingMessageListenerAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
* @author Nathan Xu
9292
* @author Wang ZhiYang
9393
*/
94-
public abstract class MessagingMessageListenerAdapter<K, V> implements ConsumerSeekAware, HandlerMethodDetect {
94+
public abstract class MessagingMessageListenerAdapter<K, V> implements ConsumerSeekAware, AsyncRepliesAware {
9595

9696
private static final SpelExpressionParser PARSER = new SpelExpressionParser();
9797

0 commit comments

Comments
 (0)