Skip to content

Resolve placeholders in both arguments in WriterResolver #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsyer opened this issue Jun 16, 2017 · 3 comments
Closed

Resolve placeholders in both arguments in WriterResolver #403

dsyer opened this issue Jun 16, 2017 · 3 comments
Labels
type: enhancement Enhancement that adds a new feature
Milestone

Comments

@dsyer
Copy link
Member

dsyer commented Jun 16, 2017

The StandardWriterResolver currently replaces placeholders (e.g. {method-name}) in the first argument, but not the second, which limits the layout of the snippets a bit. It would be useful to be able to put placeholders in both strings. That way you can have asciidoc snippets in one directory and json (or whatever) in another.

@wilkinsona wilkinsona added this to the 1.2.3.RELEASE milestone Oct 20, 2017
@wilkinsona wilkinsona added the type: enhancement Enhancement that adds a new feature label Oct 20, 2017
@wilkinsona
Copy link
Member

@dsyer Once https://build.spring.io/browse/SRD-PUB2-19 has finished, 1.2.3.BUILD-SNAPSHOT should hopefully give you what you were looking for. Please let me know if that's not the case and I'll take another look.

@dsyer
Copy link
Member Author

dsyer commented Oct 24, 2017

That looks like it would work. When does 1.2.3 make it into Spring Boot dependency management (2.0?).

@wilkinsona
Copy link
Member

Yep. Boot 2.0's currently using 1.2.2. It'll upgrade to 1.2.3 once it's released.

I may yet finish REST Docs 2.0 in time for it to sneak into Boot 2.0. That's certainly what I'd like to happen but I may run out of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancement that adds a new feature
Projects
None yet
Development

No branches or pull requests

2 participants