Skip to content

Optionality of ancestor fields is not considered when resolving the type of a field #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Dec 11, 2018 · 0 comments
Labels
Milestone

Comments

@wilkinsona
Copy link
Member

Currently, if a field is sometimes null or absent and sometimes present and its type is explicitly documented, the field itself must be marked as optional otherwise a FieldTypesDoNotMatchException will be thrown. Field type resolution should consider the field to be optional if the field itself or any of its ancestors are marked as optional. This will align its behaviour with that used when finding missing fields.

@wilkinsona wilkinsona changed the title Optional ancestor fields are not considered when resolving the type of a field Optionality of ancestor fields is not considered when resolving the type of a field Dec 11, 2018
@wilkinsona wilkinsona added the type: bug A bug label Dec 11, 2018
@wilkinsona wilkinsona added this to the 1.2.7.RELEASE milestone Dec 11, 2018
@wilkinsona wilkinsona modified the milestones: 1.2.7.RELEASE, 2.0.4.RELEASE Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant