Skip to content

Unhelpful IndexOutOfBoundException when an empty array subsection is extracted #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ public byte[] extractSubsection(byte[] payload, MediaType contentType, List<Fiel
this::prependFieldPath));
if (value instanceof List) {
List<?> extractedList = (List<?>) value;
if (extractedList.isEmpty()) {
throw new PayloadHandlingException(this.fieldPath + " identifies a section of payload, but the section is empty");
}
JsonContentHandler contentHandler = new JsonContentHandler(payload, descriptorsByPath.values());
Set<JsonFieldPath> uncommonPaths = JsonFieldPaths.from(extractedList).getUncommon().stream()
.map((path) -> JsonFieldPath
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,4 +183,12 @@ public void extractNonExistentSubsection() throws JsonParseException, JsonMappin
.hasMessage("a.c does not identify a section of the payload");
}

@Test
public void extractEmptySubsection() throws JsonParseException, JsonMappingException, IOException {
assertThatThrownBy(() -> new FieldPathPayloadSubsectionExtractor("a")
.extractSubsection("{\"a\":[]}}".getBytes(), MediaType.APPLICATION_JSON))
.isInstanceOf(PayloadHandlingException.class)
.hasMessage("a identifies a section of payload, but the section is empty");
}

}