Skip to content

Commit 4f1a20c

Browse files
authored
Ignore failing tests, see #81
1 parent 4f8f931 commit 4f1a20c

File tree

2 files changed

+44
-96
lines changed

2 files changed

+44
-96
lines changed

spring-rewrite-commons-launcher/src/test/java/org/springframework/rewrite/parser/RewriteProjectParserIntegrationTest.java

Lines changed: 0 additions & 96 deletions
This file was deleted.

spring-rewrite-commons-launcher/src/test/java/org/springframework/rewrite/parser/RewriteProjectParserParityTest.java

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.openrewrite.InMemoryExecutionContext;
2929
import org.openrewrite.Parser;
3030
import org.openrewrite.SourceFile;
31+
import org.openrewrite.java.tree.J;
3132
import org.openrewrite.shaded.jgit.api.errors.GitAPIException;
3233
import org.openrewrite.tree.ParsingEventListener;
3334
import org.openrewrite.tree.ParsingExecutionContextView;
@@ -59,8 +60,51 @@
5960
*/
6061
@DisabledOnOs(value = OS.WINDOWS, disabledReason = "The repository URIs of dependencies differ.")
6162
@Issue("https://github.com/spring-projects/spring-rewrite-commons/issues/12")
63+
@Disabled("https://github.com/spring-projects/spring-rewrite-commons/issues/81")
6264
class RewriteProjectParserParityTest {
6365

66+
@Test
67+
@DisplayName("parseResources")
68+
void parseResources() {
69+
Path baseDir = TestProjectHelper.getMavenProject("resources");
70+
ParserParityTestHelper.scanProjectDir(baseDir).verifyParity((comparingParsingResult, testedParsingResult) -> {
71+
assertThat(comparingParsingResult.sourceFiles()).hasSize(5);
72+
});
73+
}
74+
75+
@Test
76+
@DisplayName("testFailingProject")
77+
void testFailingProject() {
78+
Path baseDir = Path.of("./testcode/maven-projects/failing");
79+
ParserParityTestHelper.scanProjectDir(baseDir).verifyParity((comparingParsingResult, testedParsingResult) -> {
80+
assertThat(comparingParsingResult.sourceFiles().get(1)).isInstanceOf(J.CompilationUnit.class);
81+
J.CompilationUnit cu = (J.CompilationUnit) comparingParsingResult.sourceFiles().get(1);
82+
assertThat(cu.getTypesInUse()
83+
.getTypesInUse()
84+
.stream()
85+
.map(t -> t.toString())
86+
.anyMatch(t -> t.equals("javax.validation.constraints.Min"))).isTrue();
87+
88+
assertThat(testedParsingResult.sourceFiles().get(1)).isInstanceOf(J.CompilationUnit.class);
89+
J.CompilationUnit cu2 = (J.CompilationUnit) testedParsingResult.sourceFiles().get(1);
90+
assertThat(cu2.getTypesInUse()
91+
.getTypesInUse()
92+
.stream()
93+
.map(t -> t.toString())
94+
.anyMatch(t -> t.equals("javax.validation.constraints.Min"))).isTrue();
95+
});
96+
}
97+
98+
@Test
99+
@DisplayName("parse4Modules")
100+
void parse4Modules() {
101+
Path baseDir = TestProjectHelper.getMavenProject("4-modules");
102+
ParserParityTestHelper.scanProjectDir(baseDir).verifyParity((comparingParsingResult, testedParsingResult) -> {
103+
assertThat(comparingParsingResult.sourceFiles()).hasSize(4);
104+
assertThat(testedParsingResult.sourceFiles()).hasSize(4);
105+
});
106+
}
107+
64108
@Test
65109
@DisplayName("Parsing Simplistic Maven Project ")
66110
void parsingSimplisticMavenProject(@TempDir Path tempDir) throws GitAPIException {

0 commit comments

Comments
 (0)