Skip to content

Commit 4954a22

Browse files
committed
Polish oauth2Login Sample Test
Issue: gh-7618
1 parent 42ab673 commit 4954a22

File tree

1 file changed

+14
-37
lines changed

1 file changed

+14
-37
lines changed
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,18 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.security.samples;
16+
package sample;
17+
18+
import java.net.URI;
19+
import java.net.URL;
20+
import java.net.URLDecoder;
21+
import java.util.HashMap;
22+
import java.util.HashSet;
23+
import java.util.List;
24+
import java.util.Map;
25+
import java.util.Optional;
26+
import java.util.Set;
27+
import java.util.stream.Collectors;
1728

1829
import com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException;
1930
import com.gargoylesoftware.htmlunit.WebClient;
@@ -25,29 +36,22 @@
2536
import org.junit.Before;
2637
import org.junit.Test;
2738
import org.junit.runner.RunWith;
39+
2840
import org.springframework.beans.factory.annotation.Autowired;
29-
import org.springframework.boot.SpringBootConfiguration;
30-
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
3141
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
3242
import org.springframework.boot.test.context.SpringBootTest;
33-
import org.springframework.context.annotation.Bean;
34-
import org.springframework.context.annotation.ComponentScan;
3543
import org.springframework.http.HttpStatus;
3644
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
3745
import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity;
3846
import org.springframework.security.config.annotation.web.configuration.WebSecurityConfigurerAdapter;
3947
import org.springframework.security.core.GrantedAuthority;
40-
import org.springframework.security.oauth2.client.InMemoryOAuth2AuthorizedClientService;
41-
import org.springframework.security.oauth2.client.OAuth2AuthorizedClientService;
4248
import org.springframework.security.oauth2.client.endpoint.OAuth2AccessTokenResponseClient;
4349
import org.springframework.security.oauth2.client.endpoint.OAuth2AuthorizationCodeGrantRequest;
4450
import org.springframework.security.oauth2.client.registration.ClientRegistration;
4551
import org.springframework.security.oauth2.client.registration.ClientRegistrationRepository;
4652
import org.springframework.security.oauth2.client.userinfo.OAuth2UserRequest;
4753
import org.springframework.security.oauth2.client.userinfo.OAuth2UserService;
48-
import org.springframework.security.oauth2.client.web.AuthenticatedPrincipalOAuth2AuthorizedClientRepository;
4954
import org.springframework.security.oauth2.client.web.OAuth2AuthorizationRequestRedirectFilter;
50-
import org.springframework.security.oauth2.client.web.OAuth2AuthorizedClientRepository;
5155
import org.springframework.security.oauth2.client.web.OAuth2LoginAuthenticationFilter;
5256
import org.springframework.security.oauth2.core.OAuth2AccessToken;
5357
import org.springframework.security.oauth2.core.endpoint.OAuth2AccessTokenResponse;
@@ -60,17 +64,6 @@
6064
import org.springframework.web.util.UriComponents;
6165
import org.springframework.web.util.UriComponentsBuilder;
6266

63-
import java.net.URI;
64-
import java.net.URL;
65-
import java.net.URLDecoder;
66-
import java.util.HashMap;
67-
import java.util.HashSet;
68-
import java.util.List;
69-
import java.util.Map;
70-
import java.util.Optional;
71-
import java.util.Set;
72-
import java.util.stream.Collectors;
73-
7467
import static org.assertj.core.api.Assertions.assertThat;
7568
import static org.mockito.ArgumentMatchers.any;
7669
import static org.mockito.Mockito.mock;
@@ -85,7 +78,7 @@
8578
* @since 5.0
8679
*/
8780
@RunWith(SpringRunner.class)
88-
@SpringBootTest
81+
@SpringBootTest(classes={ OAuth2LoginApplication.class, OAuth2LoginApplicationTests.SecurityTestConfig.class })
8982
@AutoConfigureMockMvc
9083
public class OAuth2LoginApplicationTests {
9184
private static final String AUTHORIZATION_BASE_URI = "/oauth2/authorization";
@@ -405,20 +398,4 @@ private OAuth2UserService<OAuth2UserRequest, OAuth2User> mockUserService() {
405398
return userService;
406399
}
407400
}
408-
409-
@SpringBootConfiguration
410-
@EnableAutoConfiguration
411-
@ComponentScan(basePackages = "sample.web")
412-
public static class SpringBootApplicationTestConfig {
413-
414-
@Bean
415-
public OAuth2AuthorizedClientService authorizedClientService(ClientRegistrationRepository clientRegistrationRepository) {
416-
return new InMemoryOAuth2AuthorizedClientService(clientRegistrationRepository);
417-
}
418-
419-
@Bean
420-
public OAuth2AuthorizedClientRepository authorizedClientRepository(OAuth2AuthorizedClientService authorizedClientService) {
421-
return new AuthenticatedPrincipalOAuth2AuthorizedClientRepository(authorizedClientService);
422-
}
423-
}
424401
}

0 commit comments

Comments
 (0)