Skip to content

Commit 6956ed6

Browse files
committed
Polish DefaultSecurityFilterChain Logs
Reuse String manipulation logic in Spring Framework Compress whitespace Closes gh-15096
1 parent ac9bdf5 commit 6956ed6

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

web/src/main/java/org/springframework/security/web/DefaultSecurityFilterChain.java

+6-11
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
import org.springframework.core.log.LogMessage;
2929
import org.springframework.security.web.util.matcher.RequestMatcher;
30+
import org.springframework.util.StringUtils;
3031

3132
/**
3233
* Standard implementation of {@code SecurityFilterChain}.
@@ -52,18 +53,12 @@ public DefaultSecurityFilterChain(RequestMatcher requestMatcher, List<Filter> fi
5253
logger.debug(LogMessage.format("Will not secure %s", requestMatcher));
5354
}
5455
else {
55-
StringBuilder filterClassNames = new StringBuilder();
56-
String separator = ", ";
57-
58-
for (Filter f : filters) {
59-
if (!filterClassNames.isEmpty()) {
60-
filterClassNames.append(separator);
61-
}
62-
filterClassNames.append(f.getClass().getSimpleName());
56+
List<String> filterNames = new ArrayList<>();
57+
for (Filter filter : filters) {
58+
filterNames.add(filter.getClass().getSimpleName());
6359
}
64-
65-
logger.debug(
66-
LogMessage.format("Will secure %s with filters: %s", requestMatcher, filterClassNames.toString()));
60+
String names = StringUtils.collectionToDelimitedString(filterNames, ", ");
61+
logger.debug(LogMessage.format("Will secure %s with filters: %s", requestMatcher, names));
6762
}
6863
this.requestMatcher = requestMatcher;
6964
this.filters = new ArrayList<>(filters);

0 commit comments

Comments
 (0)