Skip to content

Commit 776a4c3

Browse files
larsgreferjzheaux
authored andcommitted
Use org.mockito.ArgumentMatchers in favor of org.mockito.Matchers
1 parent d843818 commit 776a4c3

File tree

45 files changed

+76
-76
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+76
-76
lines changed

config/src/test/java/org/springframework/security/config/SecurityNamespaceHandlerTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232

3333
import static org.assertj.core.api.Assertions.assertThat;
3434
import static org.assertj.core.api.Assertions.fail;
35-
import static org.mockito.Matchers.any;
36-
import static org.mockito.Matchers.eq;
35+
import static org.mockito.ArgumentMatchers.any;
36+
import static org.mockito.ArgumentMatchers.eq;
3737
import static org.powermock.api.mockito.PowerMockito.doThrow;
3838
import static org.powermock.api.mockito.PowerMockito.mock;
3939
import static org.powermock.api.mockito.PowerMockito.spy;

config/src/test/java/org/springframework/security/config/http/DefaultFilterChainValidatorTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
*/
1616
package org.springframework.security.config.http;
1717

18-
import static org.mockito.Matchers.any;
19-
import static org.mockito.Matchers.anyObject;
18+
import static org.mockito.ArgumentMatchers.any;
19+
import static org.mockito.ArgumentMatchers.anyObject;
2020
import static org.mockito.Mockito.doThrow;
2121
import static org.mockito.Mockito.mock;
2222
import static org.mockito.Mockito.verify;

config/src/test/java/org/springframework/security/config/web/server/ServerHttpSecurityTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import static org.assertj.core.api.Assertions.assertThat;
2020
import static org.mockito.BDDMockito.given;
21-
import static org.mockito.Matchers.any;
21+
import static org.mockito.ArgumentMatchers.any;
2222
import static org.mockito.Mockito.mock;
2323
import static org.mockito.Mockito.verify;
2424
import static org.mockito.Mockito.verifyZeroInteractions;

core/src/test/java/org/springframework/security/access/method/DelegatingMethodSecurityMetadataSourceTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
import org.aopalliance.intercept.MethodInvocation;
2222
import org.junit.Test;
23-
import org.mockito.Matchers;
23+
import org.mockito.ArgumentMatchers;
2424
import org.springframework.security.access.ConfigAttribute;
2525
import org.springframework.security.util.SimpleMethodInvocation;
2626

@@ -38,7 +38,7 @@ public class DelegatingMethodSecurityMetadataSourceTests {
3838
public void returnsEmptyListIfDelegateReturnsNull() throws Exception {
3939
List sources = new ArrayList();
4040
MethodSecurityMetadataSource delegate = mock(MethodSecurityMetadataSource.class);
41-
when(delegate.getAttributes(Matchers.<Method> any(), Matchers.any(Class.class)))
41+
when(delegate.getAttributes(ArgumentMatchers.<Method> any(), ArgumentMatchers.any(Class.class)))
4242
.thenReturn(null);
4343
sources.add(delegate);
4444
mds = new DelegatingMethodSecurityMetadataSource(sources);

core/src/test/java/org/springframework/security/authentication/ReactiveAuthenticationManagerAdapterTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import reactor.test.StepVerifier;
2727

2828
import static org.assertj.core.api.Assertions.assertThat;
29-
import static org.mockito.Matchers.any;
29+
import static org.mockito.ArgumentMatchers.any;
3030
import static org.mockito.Mockito.when;
3131

3232
/**

core/src/test/java/org/springframework/security/authentication/ReactiveUserDetailsServiceAuthenticationManagerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package org.springframework.security.authentication;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19-
import static org.mockito.Matchers.any;
19+
import static org.mockito.ArgumentMatchers.any;
2020
import static org.mockito.Mockito.when;
2121

2222
import org.junit.Before;

core/src/test/java/org/springframework/security/authentication/dao/DaoAuthenticationProviderTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
import static org.assertj.core.api.Assertions.fail;
2222
import static org.mockito.ArgumentMatchers.any;
2323
import static org.mockito.ArgumentMatchers.eq;
24-
import static org.mockito.Matchers.anyString;
25-
import static org.mockito.Matchers.isA;
24+
import static org.mockito.ArgumentMatchers.anyString;
25+
import static org.mockito.ArgumentMatchers.isA;
2626
import static org.mockito.Mockito.mock;
2727
import static org.mockito.Mockito.times;
2828
import static org.mockito.Mockito.verify;

core/src/test/java/org/springframework/security/authentication/jaas/DefaultJaasAuthenticationProviderTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
1919
import static org.assertj.core.api.Assertions.fail;
20-
import static org.mockito.Matchers.anyString;
21-
import static org.mockito.Matchers.eq;
22-
import static org.mockito.Matchers.isA;
20+
import static org.mockito.ArgumentMatchers.anyString;
21+
import static org.mockito.ArgumentMatchers.eq;
22+
import static org.mockito.ArgumentMatchers.isA;
2323
import static org.mockito.Mockito.doThrow;
2424
import static org.mockito.Mockito.mock;
2525
import static org.mockito.Mockito.verify;

core/src/test/java/org/springframework/security/concurrent/AbstractDelegatingSecurityContextTestSupport.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package org.springframework.security.concurrent;
1717

18-
import static org.mockito.Matchers.eq;
18+
import static org.mockito.ArgumentMatchers.eq;
1919
import static org.powermock.api.mockito.PowerMockito.doReturn;
2020
import static org.powermock.api.mockito.PowerMockito.spy;
2121

core/src/test/java/org/springframework/security/context/DelegatingApplicationListenerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import org.springframework.context.ApplicationEvent;
2424
import org.springframework.context.event.SmartApplicationListener;
2525

26-
import static org.mockito.Matchers.any;
26+
import static org.mockito.ArgumentMatchers.any;
2727
import static org.mockito.Mockito.never;
2828
import static org.mockito.Mockito.verify;
2929
import static org.mockito.Mockito.when;

core/src/test/java/org/springframework/security/core/SpringSecurityCoreVersionTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package org.springframework.security.core;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19-
import static org.mockito.Matchers.any;
19+
import static org.mockito.ArgumentMatchers.any;
2020
import static org.mockito.Mockito.never;
2121
import static org.mockito.Mockito.times;
2222
import static org.mockito.Mockito.verify;

core/src/test/java/org/springframework/security/core/userdetails/jdbc/JdbcDaoImplTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626

2727
import static org.assertj.core.api.Assertions.assertThat;
2828
import static org.assertj.core.api.Assertions.fail;
29-
import static org.mockito.Matchers.any;
30-
import static org.mockito.Matchers.eq;
29+
import static org.mockito.ArgumentMatchers.any;
30+
import static org.mockito.ArgumentMatchers.eq;
3131
import static org.mockito.Mockito.mock;
3232
import static org.mockito.Mockito.verify;
3333

messaging/src/test/java/org/springframework/security/messaging/access/intercept/ChannelSecurityInterceptorTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@
3737
import java.util.List;
3838

3939
import static org.assertj.core.api.Assertions.assertThat;
40-
import static org.mockito.Matchers.any;
41-
import static org.mockito.Matchers.eq;
40+
import static org.mockito.ArgumentMatchers.any;
41+
import static org.mockito.ArgumentMatchers.eq;
4242
import static org.mockito.Mockito.doThrow;
4343
import static org.mockito.Mockito.when;
4444

samples/boot/oauth2login/src/integration-test/java/org/springframework/security/samples/OAuth2LoginApplicationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
import java.util.stream.Collectors;
7373

7474
import static org.assertj.core.api.Assertions.assertThat;
75-
import static org.mockito.Matchers.any;
75+
import static org.mockito.ArgumentMatchers.any;
7676
import static org.mockito.Mockito.mock;
7777
import static org.mockito.Mockito.when;
7878

taglibs/src/test/java/org/springframework/security/taglibs/authz/AbstractAuthorizeTagTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717

1818
import static org.assertj.core.api.Assertions.*;
1919

20-
import static org.mockito.Matchers.any;
21-
import static org.mockito.Matchers.eq;
20+
import static org.mockito.ArgumentMatchers.any;
21+
import static org.mockito.ArgumentMatchers.eq;
2222
import static org.mockito.Mockito.mock;
2323
import static org.mockito.Mockito.verify;
2424
import static org.mockito.Mockito.when;

test/src/test/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessorsAuthenticationTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
package org.springframework.security.test.web.servlet.request;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19-
import static org.mockito.Matchers.any;
20-
import static org.mockito.Matchers.eq;
19+
import static org.mockito.ArgumentMatchers.any;
20+
import static org.mockito.ArgumentMatchers.eq;
2121
import static org.mockito.Mockito.verify;
2222
import static org.powermock.api.mockito.PowerMockito.spy;
2323
import static org.powermock.api.mockito.PowerMockito.when;

test/src/test/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessorsSecurityContextTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
package org.springframework.security.test.web.servlet.request;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19-
import static org.mockito.Matchers.any;
20-
import static org.mockito.Matchers.eq;
19+
import static org.mockito.ArgumentMatchers.any;
20+
import static org.mockito.ArgumentMatchers.eq;
2121
import static org.mockito.Mockito.verify;
2222
import static org.powermock.api.mockito.PowerMockito.spy;
2323
import static org.powermock.api.mockito.PowerMockito.when;
@@ -78,4 +78,4 @@ private void mockWebTestUtils() {
7878
spy(WebTestUtils.class);
7979
when(WebTestUtils.getSecurityContextRepository(request)).thenReturn(repository);
8080
}
81-
}
81+
}

test/src/test/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessorsUserDetailsTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
package org.springframework.security.test.web.servlet.request;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19-
import static org.mockito.Matchers.any;
20-
import static org.mockito.Matchers.eq;
19+
import static org.mockito.ArgumentMatchers.any;
20+
import static org.mockito.ArgumentMatchers.eq;
2121
import static org.mockito.Mockito.verify;
2222
import static org.powermock.api.mockito.PowerMockito.spy;
2323
import static org.powermock.api.mockito.PowerMockito.when;
@@ -82,4 +82,4 @@ private void mockWebTestUtils() {
8282
spy(WebTestUtils.class);
8383
when(WebTestUtils.getSecurityContextRepository(request)).thenReturn(repository);
8484
}
85-
}
85+
}

test/src/test/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessorsUserTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
package org.springframework.security.test.web.servlet.request;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19-
import static org.mockito.Matchers.any;
20-
import static org.mockito.Matchers.eq;
19+
import static org.mockito.ArgumentMatchers.any;
20+
import static org.mockito.ArgumentMatchers.eq;
2121
import static org.mockito.Mockito.verify;
2222
import static org.powermock.api.mockito.PowerMockito.spy;
2323
import static org.powermock.api.mockito.PowerMockito.when;

test/src/test/java/org/springframework/security/test/web/servlet/setup/SecurityMockMvcConfigurerTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
import org.springframework.test.web.servlet.setup.ConfigurableMockMvcBuilder;
2929
import org.springframework.web.context.WebApplicationContext;
3030

31-
import static org.mockito.Matchers.anyString;
32-
import static org.mockito.Matchers.eq;
31+
import static org.mockito.ArgumentMatchers.anyString;
32+
import static org.mockito.ArgumentMatchers.eq;
3333
import static org.mockito.Mockito.verify;
3434
import static org.mockito.Mockito.when;
3535

web/src/test/java/org/springframework/security/web/access/DelegatingAccessDeniedHandlerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package org.springframework.security.web.access;
1717

18-
import static org.mockito.Matchers.any;
18+
import static org.mockito.ArgumentMatchers.any;
1919
import static org.mockito.Mockito.never;
2020
import static org.mockito.Mockito.verify;
2121

web/src/test/java/org/springframework/security/web/access/ExceptionTranslationFilterTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import static org.assertj.core.api.Assertions.assertThat;
1919
import static org.assertj.core.api.Assertions.assertThatThrownBy;
2020
import static org.assertj.core.api.Assertions.fail;
21-
import static org.mockito.Matchers.any;
21+
import static org.mockito.ArgumentMatchers.any;
2222
import static org.mockito.Mockito.doThrow;
2323
import static org.mockito.Mockito.mock;
2424
import static org.mockito.Mockito.verifyZeroInteractions;

web/src/test/java/org/springframework/security/web/access/expression/WebExpressionVoterTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package org.springframework.security.web.access.expression;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19-
import static org.mockito.Matchers.any;
19+
import static org.mockito.ArgumentMatchers.any;
2020
import static org.mockito.Mockito.mock;
2121
import static org.mockito.Mockito.when;
2222

web/src/test/java/org/springframework/security/web/authentication/AbstractAuthenticationProcessingFilterTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818

1919
import static org.assertj.core.api.Assertions.assertThat;
2020
import static org.assertj.core.api.Assertions.fail;
21-
import static org.mockito.Matchers.any;
22-
import static org.mockito.Matchers.anyString;
23-
import static org.mockito.Matchers.eq;
21+
import static org.mockito.ArgumentMatchers.any;
22+
import static org.mockito.ArgumentMatchers.anyString;
23+
import static org.mockito.ArgumentMatchers.eq;
2424
import static org.mockito.Mockito.mock;
2525
import static org.mockito.Mockito.verify;
2626

web/src/test/java/org/springframework/security/web/authentication/logout/CompositeLogoutHandlerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
import org.springframework.security.core.Authentication;
3131

3232
import static org.assertj.core.api.Assertions.fail;
33-
import static org.mockito.Matchers.any;
33+
import static org.mockito.ArgumentMatchers.any;
3434
import static org.mockito.Mockito.doThrow;
3535
import static org.mockito.Mockito.inOrder;
3636
import static org.mockito.Mockito.mock;

web/src/test/java/org/springframework/security/web/authentication/preauth/AbstractPreAuthenticatedProcessingFilterTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
1919
import static org.assertj.core.api.Assertions.fail;
20-
import static org.mockito.Matchers.any;
20+
import static org.mockito.ArgumentMatchers.any;
2121
import static org.mockito.Mockito.mock;
2222
import static org.mockito.Mockito.verify;
2323
import static org.mockito.Mockito.verifyZeroInteractions;

web/src/test/java/org/springframework/security/web/authentication/preauth/websphere/WebSpherePreAuthenticatedProcessingFilterTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package org.springframework.security.web.authentication.preauth.websphere;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19-
import static org.mockito.Matchers.any;
19+
import static org.mockito.ArgumentMatchers.any;
2020
import static org.mockito.Mockito.mock;
2121
import static org.mockito.Mockito.when;
2222

web/src/test/java/org/springframework/security/web/authentication/rememberme/JdbcTokenRepositoryImplTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
package org.springframework.security.web.authentication.rememberme;
1818

1919
import static org.assertj.core.api.Assertions.assertThat;
20-
import static org.mockito.Matchers.any;
21-
import static org.mockito.Matchers.anyString;
22-
import static org.mockito.Matchers.eq;
20+
import static org.mockito.ArgumentMatchers.any;
21+
import static org.mockito.ArgumentMatchers.anyString;
22+
import static org.mockito.ArgumentMatchers.eq;
2323
import static org.mockito.Mockito.mock;
2424
import static org.mockito.Mockito.verify;
2525
import static org.mockito.Mockito.verifyNoMoreInteractions;

web/src/test/java/org/springframework/security/web/authentication/session/ConcurrentSessionControlAuthenticationStrategyTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
package org.springframework.security.web.authentication.session;
1818

1919
import static org.assertj.core.api.Assertions.assertThat;
20-
import static org.mockito.Matchers.any;
21-
import static org.mockito.Matchers.anyBoolean;
20+
import static org.mockito.ArgumentMatchers.any;
21+
import static org.mockito.ArgumentMatchers.anyBoolean;
2222
import static org.mockito.Mockito.when;
2323

2424
import java.util.Arrays;

web/src/test/java/org/springframework/security/web/concurrent/ConcurrentSessionFilterTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@
4040
import org.springframework.security.web.session.SimpleRedirectSessionInformationExpiredStrategy;
4141

4242
import static org.assertj.core.api.Assertions.assertThat;
43-
import static org.mockito.Matchers.any;
44-
import static org.mockito.Matchers.anyString;
45-
import static org.mockito.Matchers.eq;
43+
import static org.mockito.ArgumentMatchers.any;
44+
import static org.mockito.ArgumentMatchers.anyString;
45+
import static org.mockito.ArgumentMatchers.eq;
4646
import static org.mockito.Mockito.mock;
4747
import static org.mockito.Mockito.verify;
4848
import static org.mockito.Mockito.verifyZeroInteractions;

web/src/test/java/org/springframework/security/web/context/HttpSessionSecurityContextRepositoryTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
import org.springframework.security.core.context.SecurityContextHolder;
4444

4545
import static org.assertj.core.api.Assertions.assertThat;
46-
import static org.mockito.Matchers.anyBoolean;
46+
import static org.mockito.ArgumentMatchers.anyBoolean;
4747
import static org.mockito.Mockito.never;
4848
import static org.mockito.Mockito.reset;
4949
import static org.mockito.Mockito.verify;

web/src/test/java/org/springframework/security/web/csrf/CsrfAuthenticationStrategyTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
import org.springframework.security.authentication.TestingAuthenticationToken;
3030

3131
import static org.assertj.core.api.Assertions.assertThat;
32-
import static org.mockito.Matchers.any;
33-
import static org.mockito.Matchers.eq;
32+
import static org.mockito.ArgumentMatchers.any;
33+
import static org.mockito.ArgumentMatchers.eq;
3434
import static org.mockito.Mockito.never;
3535
import static org.mockito.Mockito.verify;
3636
import static org.mockito.Mockito.when;

web/src/test/java/org/springframework/security/web/csrf/CsrfFilterTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@
3737
import org.springframework.security.web.util.matcher.RequestMatcher;
3838

3939
import static org.assertj.core.api.Assertions.assertThat;
40-
import static org.mockito.Matchers.any;
41-
import static org.mockito.Matchers.eq;
40+
import static org.mockito.ArgumentMatchers.any;
41+
import static org.mockito.ArgumentMatchers.eq;
4242
import static org.mockito.Mockito.never;
4343
import static org.mockito.Mockito.times;
4444
import static org.mockito.Mockito.verify;

web/src/test/java/org/springframework/security/web/debug/DebugFilterTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
package org.springframework.security.web.debug;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19-
import static org.mockito.Matchers.anyString;
20-
import static org.mockito.Matchers.eq;
19+
import static org.mockito.ArgumentMatchers.anyString;
20+
import static org.mockito.ArgumentMatchers.eq;
2121
import static org.mockito.Mockito.never;
2222
import static org.mockito.Mockito.verify;
2323
import static org.mockito.Mockito.when;

web/src/test/java/org/springframework/security/web/header/HeaderWriterFilterTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
import org.springframework.mock.web.MockHttpServletResponse;
3939

4040
import static org.assertj.core.api.Assertions.assertThat;
41-
import static org.mockito.Matchers.any;
41+
import static org.mockito.ArgumentMatchers.any;
4242
import static org.mockito.Mockito.verify;
4343
import static org.mockito.Mockito.verifyNoMoreInteractions;
4444
import static org.mockito.Mockito.verifyZeroInteractions;

web/src/test/java/org/springframework/security/web/server/authentication/AuthenticationWebFilterTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
import org.springframework.test.web.reactive.server.WebTestClient;
3737

3838
import static org.assertj.core.api.Assertions.assertThat;
39-
import static org.mockito.Matchers.any;
40-
import static org.mockito.Matchers.eq;
39+
import static org.mockito.ArgumentMatchers.any;
40+
import static org.mockito.ArgumentMatchers.eq;
4141
import static org.mockito.Mockito.*;
4242

4343
/**

0 commit comments

Comments
 (0)