Satisfy checkstyle

Author: Haarolean

ldap/src/main/java/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java

@@ -69,7 +69,7 @@
  * attribute.
  * <p>
  * <h3>Active Directory Sub-Error Codes</h3>
- *
+ * <p>
  * When an authentication fails, resulting in a standard LDAP 49 error code, Active
  * Directory also supplies its own sub-error codes within the error message. These will be
  * used to provide additional log information on why an authentication has failed. Typical
@@ -85,7 +85,7 @@
  * <li>773 - user must reset password</li>
  * <li>775 - account locked</li>
  * </ul>
- *
+ * <p>
  * If you set the {@link #setConvertSubErrorCodesToExceptions(boolean)
  * convertSubErrorCodesToExceptions} property to {@code true}, the codes will also be used
  * to control the exception raised.
@@ -143,7 +143,7 @@ public ActiveDirectoryLdapAuthenticationProvider(String domain, String url, Stri
 		this.domain = StringUtils.hasText(domain) ? domain.toLowerCase() : null;
 		this.url = url;
 		this.rootDn = StringUtils.hasText(rootDn) ? rootDn.toLowerCase() : null;
-		this.setAuthoritiesPopulator(authoritiesPopulator);
+		this.setAuthoritiesPopulator(this.authoritiesPopulator);
 	}
 
 	/**
@@ -155,7 +155,7 @@ public ActiveDirectoryLdapAuthenticationProvider(String domain, String url) {
 		this.domain = StringUtils.hasText(domain) ? domain.toLowerCase() : null;
 		this.url = url;
 		this.rootDn = (this.domain != null) ? rootDnFromDomain(this.domain) : null;
-		this.setAuthoritiesPopulator(authoritiesPopulator);
+		this.setAuthoritiesPopulator(this.authoritiesPopulator);
 	}
 
 	@Override
@@ -182,7 +182,7 @@ protected DirContextOperations doAuthentication(UsernamePasswordAuthenticationTo
 	@Override
 	protected Collection<? extends GrantedAuthority> loadUserAuthorities(DirContextOperations userData, String username,
 			String password) {
-		return authoritiesPopulator.getGrantedAuthorities(userData, username);
+		return this.authoritiesPopulator.getGrantedAuthorities(userData, username);
 	}
 
 	private DirContext bindAsUser(String username, String password) {
@@ -363,7 +363,6 @@ public void setConvertSubErrorCodesToExceptions(boolean convertSubErrorCodesToEx
 	 * Defaults to: {@code (&(objectClass=user)(userPrincipalName={0}))}
 	 * </p>
 	 * @param searchFilter the filter string
-	 *
 	 * @since 3.2.6
 	 */
 	public void setSearchFilter(String searchFilter) {

ldap/src/main/java/org/springframework/security/ldap/authentication/ad/DefaultActiveDirectoryAuthoritiesPopulator.java

@@ -16,20 +16,21 @@
 
 package org.springframework.security.ldap.authentication.ad;
 
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
+
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
+
 import org.springframework.ldap.core.DirContextOperations;
 import org.springframework.ldap.core.DistinguishedName;
 import org.springframework.security.core.GrantedAuthority;
 import org.springframework.security.core.authority.AuthorityUtils;
 import org.springframework.security.core.authority.SimpleGrantedAuthority;
 import org.springframework.security.ldap.userdetails.LdapAuthoritiesPopulator;
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.List;
-
 /**
  * The default strategy for obtaining user role information from the active directory.
  * Creates the user authority list from the values of the {@code memberOf} attribute