Update exception variable names

Consistently use `ex` for caught exception and `cause` for Exception
constructor arguments.

Issue gh-8945

Author: philwebb

acl/src/main/java/org/springframework/security/acls/domain/IdentityUnavailableException.java

@@ -34,10 +34,10 @@ public IdentityUnavailableException(String msg) {
 	 * Constructs an <code>IdentityUnavailableException</code> with the specified message
 	 * and root cause.
 	 * @param msg the detail message
-	 * @param t root cause
+	 * @param cause root cause
 	 */
-	public IdentityUnavailableException(String msg, Throwable t) {
-		super(msg, t);
+	public IdentityUnavailableException(String msg, Throwable cause) {
+		super(msg, cause);
 	}
 
 }

acl/src/main/java/org/springframework/security/acls/domain/ObjectIdentityImpl.java

@@ -77,8 +77,8 @@ public ObjectIdentityImpl(Object object) throws IdentityUnavailableException {
 			Method method = typeClass.getMethod("getId", new Class[] {});
 			result = method.invoke(object);
 		}
-		catch (Exception e) {
-			throw new IdentityUnavailableException("Could not extract identity from object " + object, e);
+		catch (Exception ex) {
+			throw new IdentityUnavailableException("Could not extract identity from object " + object, ex);
 		}
 
 		Assert.notNull(result, "getId() is required to return a non-null value");

acl/src/main/java/org/springframework/security/acls/jdbc/AclClassIdUtils.java

@@ -85,8 +85,8 @@ private boolean hasValidClassIdType(ResultSet resultSet) {
 		try {
 			hasClassIdType = classIdTypeFrom(resultSet) != null;
 		}
-		catch (SQLException e) {
-			log.debug("Unable to obtain the class id type", e);
+		catch (SQLException ex) {
+			log.debug("Unable to obtain the class id type", ex);
 		}
 		return hasClassIdType;
 	}
@@ -101,8 +101,8 @@ private <T extends Serializable> Class<T> classIdTypeFrom(String className) {
 			try {
 				targetType = Class.forName(className);
 			}
-			catch (ClassNotFoundException e) {
-				log.debug("Unable to find class id type on classpath", e);
+			catch (ClassNotFoundException ex) {
+				log.debug("Unable to find class id type on classpath", ex);
 			}
 		}
 		return targetType;

acl/src/main/java/org/springframework/security/acls/jdbc/BasicLookupStrategy.java

@@ -194,26 +194,26 @@ private List<AccessControlEntryImpl> readAces(AclImpl acl) {
 		try {
 			return (List<AccessControlEntryImpl>) this.fieldAces.get(acl);
 		}
-		catch (IllegalAccessException e) {
-			throw new IllegalStateException("Could not obtain AclImpl.aces field", e);
+		catch (IllegalAccessException ex) {
+			throw new IllegalStateException("Could not obtain AclImpl.aces field", ex);
 		}
 	}
 
 	private void setAclOnAce(AccessControlEntryImpl ace, AclImpl acl) {
 		try {
 			this.fieldAcl.set(ace, acl);
 		}
-		catch (IllegalAccessException e) {
-			throw new IllegalStateException("Could not or set AclImpl on AccessControlEntryImpl fields", e);
+		catch (IllegalAccessException ex) {
+			throw new IllegalStateException("Could not or set AclImpl on AccessControlEntryImpl fields", ex);
 		}
 	}
 
 	private void setAces(AclImpl acl, List<AccessControlEntryImpl> aces) {
 		try {
 			this.fieldAces.set(acl, aces);
 		}
-		catch (IllegalAccessException e) {
-			throw new IllegalStateException("Could not set AclImpl entries", e);
+		catch (IllegalAccessException ex) {
+			throw new IllegalStateException("Could not set AclImpl entries", ex);
 		}
 	}
 

acl/src/main/java/org/springframework/security/acls/model/AlreadyExistsException.java

@@ -34,10 +34,10 @@ public AlreadyExistsException(String msg) {
 	 * Constructs an <code>AlreadyExistsException</code> with the specified message and
 	 * root cause.
 	 * @param msg the detail message
-	 * @param t root cause
+	 * @param cause root cause
 	 */
-	public AlreadyExistsException(String msg, Throwable t) {
-		super(msg, t);
+	public AlreadyExistsException(String msg, Throwable cause) {
+		super(msg, cause);
 	}
 
 }

acl/src/main/java/org/springframework/security/acls/model/ChildrenExistException.java

@@ -34,10 +34,10 @@ public ChildrenExistException(String msg) {
 	 * Constructs an <code>ChildrenExistException</code> with the specified message and
 	 * root cause.
 	 * @param msg the detail message
-	 * @param t root cause
+	 * @param cause root cause
 	 */
-	public ChildrenExistException(String msg, Throwable t) {
-		super(msg, t);
+	public ChildrenExistException(String msg, Throwable cause) {
+		super(msg, cause);
 	}
 
 }

acl/src/main/java/org/springframework/security/acls/model/NotFoundException.java

@@ -34,10 +34,10 @@ public NotFoundException(String msg) {
 	 * Constructs an <code>NotFoundException</code> with the specified message and root
 	 * cause.
 	 * @param msg the detail message
-	 * @param t root cause
+	 * @param cause root cause
 	 */
-	public NotFoundException(String msg, Throwable t) {
-		super(msg, t);
+	public NotFoundException(String msg, Throwable cause) {
+		super(msg, cause);
 	}
 
 }

acl/src/main/java/org/springframework/security/acls/model/UnloadedSidException.java

@@ -36,10 +36,10 @@ public UnloadedSidException(String msg) {
 	 * Constructs an <code>NotFoundException</code> with the specified message and root
 	 * cause.
 	 * @param msg the detail message
-	 * @param t root cause
+	 * @param cause root cause
 	 */
-	public UnloadedSidException(String msg, Throwable t) {
-		super(msg, t);
+	public UnloadedSidException(String msg, Throwable cause) {
+		super(msg, cause);
 	}
 
 }

acl/src/test/java/org/springframework/security/acls/domain/AclImplTests.java

@@ -628,8 +628,8 @@ public MutableAcl updateAcl(MutableAcl acl) throws NotFoundException {
 							((AuditableAccessControlEntry) ac).isAuditFailure()));
 				}
 			}
-			catch (IllegalAccessException e) {
-				e.printStackTrace();
+			catch (IllegalAccessException ex) {
+				ex.printStackTrace();
 			}
 
 			return acl;

acl/src/test/java/org/springframework/security/acls/jdbc/JdbcMutableAclServiceTests.java

@@ -121,9 +121,9 @@ public void createTables() throws Exception {
 			// new DatabaseSeeder(dataSource, new
 			// ClassPathResource("createAclSchemaPostgres.sql"));
 		}
-		catch (Exception e) {
-			e.printStackTrace();
-			throw e;
+		catch (Exception ex) {
+			ex.printStackTrace();
+			throw ex;
 		}
 	}