Skip to content

Commit 981d35a

Browse files
committed
Add ClientRegistration.Builder.registrationId
Fixes: gh-5527
1 parent 2cd5482 commit 981d35a

File tree

2 files changed

+31
-0
lines changed

2 files changed

+31
-0
lines changed

oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/registration/ClientRegistration.java

+11
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,17 @@ private Builder(String registrationId) {
255255
this.registrationId = registrationId;
256256
}
257257

258+
/**
259+
* Sets the client identifier.
260+
*
261+
* @param registrationId the registration id
262+
* @return the {@link Builder}
263+
*/
264+
public Builder registrationId(String registrationId) {
265+
this.registrationId = registrationId;
266+
return this;
267+
}
268+
258269
/**
259270
* Sets the client identifier.
260271
*

oauth2/oauth2-client/src/test/java/org/springframework/security/oauth2/client/registration/ClientRegistrationTests.java

+20
Original file line numberDiff line numberDiff line change
@@ -351,4 +351,24 @@ public void buildWhenImplicitGrantClientNameIsNullThenThrowIllegalArgumentExcept
351351
.clientName(null)
352352
.build();
353353
}
354+
355+
@Test
356+
public void buildWhenOverrideRegistrationIdThenOverridden() {
357+
String overriddenId = "override";
358+
ClientRegistration registration = ClientRegistration.withRegistrationId(REGISTRATION_ID)
359+
.registrationId(overriddenId)
360+
.clientId(CLIENT_ID)
361+
.clientSecret(CLIENT_SECRET)
362+
.clientAuthenticationMethod(ClientAuthenticationMethod.BASIC)
363+
.authorizationGrantType(AuthorizationGrantType.AUTHORIZATION_CODE)
364+
.redirectUriTemplate(REDIRECT_URI)
365+
.scope(SCOPES.toArray(new String[0]))
366+
.authorizationUri(AUTHORIZATION_URI)
367+
.tokenUri(TOKEN_URI)
368+
.jwkSetUri(JWK_SET_URI)
369+
.clientName(CLIENT_NAME)
370+
.build();
371+
372+
assertThat(registration.getRegistrationId()).isEqualTo(overriddenId);
373+
}
354374
}

0 commit comments

Comments
 (0)