Skip to content

Commit c9b5ff9

Browse files
committed
Remove millis from method, the type Duration is agnostic
#7260 (comment)
1 parent f606b83 commit c9b5ff9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/serviceprovider/authentication/OpenSamlAuthenticationProvider.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public class OpenSamlAuthenticationProvider implements AuthenticationProvider {
8787

8888
private final OpenSamlImplementation saml = OpenSamlImplementation.getInstance();
8989
private GrantedAuthoritiesMapper authoritiesMapper = (a -> a);
90-
private Duration responseTimeValidationSkewMillis = Duration.ofMillis(1000 * 60 * 5); // 5 minutes
90+
private Duration responseTimeValidationSkew = Duration.ofMillis(1000 * 60 * 5); // 5 minutes
9191

9292
private String getUsername(Saml2AuthenticationToken token, Assertion assertion) {
9393
final Subject subject = assertion.getSubject();
@@ -161,7 +161,7 @@ private boolean isValidAssertion(String recipient, Assertion a, Saml2Authenticat
161161
validationParams.put(SAML2AssertionValidationParameters.SIGNATURE_REQUIRED, false);
162162
validationParams.put(
163163
SAML2AssertionValidationParameters.CLOCK_SKEW,
164-
this.responseTimeValidationSkewMillis
164+
this.responseTimeValidationSkew
165165
);
166166
validationParams.put(
167167
SAML2AssertionValidationParameters.COND_VALID_AUDIENCES,
@@ -306,8 +306,8 @@ public void setAuthoritiesMapper(GrantedAuthoritiesMapper authoritiesMapper) {
306306
this.authoritiesMapper = authoritiesMapper;
307307
}
308308

309-
public void setResponseTimeValidationSkewMillis(Duration responseTimeValidationSkewMillis) {
310-
this.responseTimeValidationSkewMillis = responseTimeValidationSkewMillis;
309+
public void setResponseTimeValidationSkew(Duration responseTimeValidationSkew) {
310+
this.responseTimeValidationSkew = responseTimeValidationSkew;
311311
}
312312

313313
private List<? extends GrantedAuthority> getAssertionAuthorities(Assertion assertion) {

0 commit comments

Comments
 (0)