Skip to content

Commit ecf6cac

Browse files
committed
Re-Enable Disabled OpenSAML Tests
Issue gh-15395
1 parent c9d0837 commit ecf6cac

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

saml2/saml2-service-provider/src/opensaml4Test/java/org/springframework/security/saml2/provider/service/registration/OpenSaml4AssertingPartyMetadataRepositoryTests.java

-6
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import okhttp3.mockwebserver.RecordedRequest;
3838
import org.junit.jupiter.api.AfterAll;
3939
import org.junit.jupiter.api.BeforeAll;
40-
import org.junit.jupiter.api.Disabled;
4140
import org.junit.jupiter.api.Test;
4241
import org.opensaml.core.xml.XMLObject;
4342
import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport;
@@ -106,7 +105,6 @@ public static void shutdown() throws Exception {
106105
}
107106

108107
@Test
109-
@Disabled("See gh-15395")
110108
public void withMetadataUrlLocationWhenResolvableThenFindByEntityIdReturns() throws Exception {
111109
AssertingPartyMetadataRepository parties = OpenSaml4AssertingPartyMetadataRepository
112110
.withTrustedMetadataLocation(web.url("/entity.xml").toString())
@@ -121,7 +119,6 @@ public void withMetadataUrlLocationWhenResolvableThenFindByEntityIdReturns() thr
121119
}
122120

123121
@Test
124-
@Disabled("See gh-15395")
125122
public void withMetadataUrlLocationnWhenResolvableThenIteratorReturns() throws Exception {
126123
List<AssertingPartyMetadata> parties = new ArrayList<>();
127124
OpenSaml4AssertingPartyMetadataRepository.withTrustedMetadataLocation(web.url("/entities.xml").toString())
@@ -218,7 +215,6 @@ public void withMetadataClasspathLocationWhenNotFoundThenSaml2Exception() {
218215
}
219216

220217
@Test
221-
@Disabled("See gh-15395")
222218
public void withTrustedMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
223219
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
224220
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@@ -237,7 +233,6 @@ public void withTrustedMetadataLocationWhenMatchingCredentialsThenVerifiesSignat
237233
}
238234

239235
@Test
240-
@Disabled("See gh-15395")
241236
public void withTrustedMetadataLocationWhenMismatchingCredentialsThenSaml2Exception() throws IOException {
242237
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
243238
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@@ -332,7 +327,6 @@ public void withMetadataLocationWhenNoCredentialsThenException() {
332327
}
333328

334329
@Test
335-
@Disabled("See gh-15395")
336330
public void withMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
337331
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
338332
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);

saml2/saml2-service-provider/src/opensaml5Test/java/org/springframework/security/saml2/provider/service/registration/OpenSaml5AssertingPartyMetadataRepositoryTests.java

-6
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
import okhttp3.mockwebserver.RecordedRequest;
3838
import org.junit.jupiter.api.AfterAll;
3939
import org.junit.jupiter.api.BeforeAll;
40-
import org.junit.jupiter.api.Disabled;
4140
import org.junit.jupiter.api.Test;
4241
import org.opensaml.core.xml.XMLObject;
4342
import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport;
@@ -106,7 +105,6 @@ public static void shutdown() throws Exception {
106105
}
107106

108107
@Test
109-
@Disabled("See gh-15395")
110108
public void withMetadataUrlLocationWhenResolvableThenFindByEntityIdReturns() throws Exception {
111109
AssertingPartyMetadataRepository parties = OpenSaml5AssertingPartyMetadataRepository
112110
.withTrustedMetadataLocation(web.url("/entity.xml").toString())
@@ -121,7 +119,6 @@ public void withMetadataUrlLocationWhenResolvableThenFindByEntityIdReturns() thr
121119
}
122120

123121
@Test
124-
@Disabled("See gh-15395")
125122
public void withMetadataUrlLocationnWhenResolvableThenIteratorReturns() throws Exception {
126123
List<AssertingPartyMetadata> parties = new ArrayList<>();
127124
OpenSaml5AssertingPartyMetadataRepository.withTrustedMetadataLocation(web.url("/entities.xml").toString())
@@ -218,7 +215,6 @@ public void withMetadataClasspathLocationWhenNotFoundThenSaml2Exception() {
218215
}
219216

220217
@Test
221-
@Disabled("See gh-15395")
222218
public void withTrustedMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
223219
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
224220
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@@ -237,7 +233,6 @@ public void withTrustedMetadataLocationWhenMatchingCredentialsThenVerifiesSignat
237233
}
238234

239235
@Test
240-
@Disabled("See gh-15395")
241236
public void withTrustedMetadataLocationWhenMismatchingCredentialsThenSaml2Exception() throws IOException {
242237
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
243238
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@@ -332,7 +327,6 @@ public void withMetadataLocationWhenNoCredentialsThenException() {
332327
}
333328

334329
@Test
335-
@Disabled("See gh-15395")
336330
public void withMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
337331
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
338332
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);

0 commit comments

Comments
 (0)