Skip to content

Subject and NameId considered mandatory #14199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AkashB23 opened this issue Nov 27, 2023 · 1 comment
Closed

Subject and NameId considered mandatory #14199

AkashB23 opened this issue Nov 27, 2023 · 1 comment
Assignees
Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@AkashB23
Copy link

As per the implementation Subject and NameId in subject are considered mandatory and library do not provide any means to override it

But according to SAML2 spec subject and NameId are optional, can we update the validation to have as optional
image
image

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 27, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Nov 27, 2023

Thanks for bringing this up, @AkashB23. I believe we are already underway in #12136, so I'll mark this as a duplicate. Please feel free to contribute to the conversation over there.

@jzheaux jzheaux closed this as completed Nov 27, 2023
@jzheaux jzheaux self-assigned this Nov 27, 2023
@jzheaux jzheaux added status: duplicate A duplicate of another issue type: enhancement A general enhancement in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants