Skip to content

AuthorizationRequestRedirectFilter needs a way to customize errors #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Oct 17, 2017 · 1 comment
Closed

AuthorizationRequestRedirectFilter needs a way to customize errors #4641

rwinch opened this issue Oct 17, 2017 · 1 comment
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: invalid An issue that we don't feel is valid

Comments

@rwinch
Copy link
Member

rwinch commented Oct 17, 2017

Summary

Currently sendRedirectForAuthorization can throw an IllegalArgumentException if the client registration is not found. This means there is a big stacktrace provided on the screen by default. We should allow some strategy to be used for handling the error (i.e. rendering an error page, forwarding to the error page, etc).
@rwinch rwinch added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Oct 17, 2017
@jgrandja jgrandja added this to the 5.1.0.M1 milestone Dec 12, 2017
@rwinch rwinch modified the milestones: 5.1.0.M1, 5.1.0.RC1 Dec 19, 2017
@jgrandja jgrandja removed this from the 5.1.0.M2 milestone Jul 24, 2018
@jgrandja jgrandja mentioned this issue Jul 26, 2018
Closed
@rwinch rwinch added type: enhancement A general enhancement and removed New Feature labels May 3, 2019
@jgrandja
Copy link
Contributor

This issue is no longer valid as IllegalArgumentException is not thrown and instead response.sendError() is used.

@jgrandja jgrandja added status: invalid An issue that we don't feel is valid and removed type: enhancement A general enhancement labels May 18, 2021
@jgrandja jgrandja self-assigned this May 18, 2021
@willemvd willemvd mentioned this issue Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwinch @jgrandja