-
Notifications
You must be signed in to change notification settings - Fork 6k
Support OIDC login_hint for clients #5244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related #4911 |
Hi @tnwang. I'm currently looking at implementing this feature. This is what I'm thinking. The simplest solution to allow for custom authentication request parameters would be to allow the user to provide the request parameters via the For example, if you would like to provide the
We would ensure that any request parameters supplied in the Would this strategy meet your requirement? |
I think long term the use case of the login hint would be that applications collect information up front (the basic example given in OIDC spec is the username) so that the OIDC provider doesn't need to prompt for it again. With UAA, since we support multiple identity providers, an app may implement this for selecting among different identity providers (for example, I might have a Consumer Facing SAML provider vs. an Enterprise facing SAML provider, and the user is specifying whether they are a customer or an employee logging into a support app, where login hint helps the app use the right identity provider). I'm not sure how flexible the login_hint parameter as part of the URI in the ClientRegistration is if we wanted to update the value later when making the per-user call out to the identity provider. |
@tnwang Thanks for the detailed use case. This helps. And agreed a static |
Closed via 779597a |
@tnwang This feature has been merged. Take a look at the following tests for usage: Line 306 in 779597a
Line 337 in 779597a
Also, I'm planning on merging #5521 shortly as this is required in order to configure a custom Please let me know how this goes and if it suits your requirements. |
Looks good to me at a glance, especially the added ability for arbitrary request parameters. Looping in @aashah as well in case he has any thoughts. |
Summary
Support applications acting as clients providing their arbitrary values for OIDC login hint. This is passed along via the
login_hint
parameter during the OpenID Authentication Request.It is standard to represent the user you want to use to login, but as per spec this can be customized for use by the identity provider (spec later mentions it as a string value parameter). As such, applications could be passing dynamic values (e.g. username provided by user to client, or in the case of UAA the application may choose to perform custom logic to determine which identity provider should be used).
http://openid.net/specs/openid-connect-core-1_0.html#AuthRequest
The text was updated successfully, but these errors were encountered: