Skip to content

OAuth2Token interface for AbstractOAuth2Token #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue Jul 11, 2018 · 1 comment
Closed

OAuth2Token interface for AbstractOAuth2Token #5502

jzheaux opened this issue Jul 11, 2018 · 1 comment
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jul 11, 2018

This still needs to be thought through a bit, but contracts like these:

public class AbstractOAuth2TokenAuthenticationToken<T extends AbstractOAuth2Token>

would be a bit more flexible if the bounding type were an interface instead of an abstract class, for example:

public class AbstractOAuth2TokenAuthenticationToken<T extends OAuth2Token>

Or, perhaps something more generic:

public class AbstractOAuth2TokenAuthenticationToken<T extends Token>

These would imply the creation of an interface for AbstractOAuth2Token to extend, something like:

public interface Token {
    String getValue();
}

public abstract class AbstractOAuth2Token implements Token {
   // ...
}

Logging this ticket so that we can start the discussion.

@jzheaux jzheaux added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Jul 11, 2018
@jgrandja jgrandja self-assigned this Nov 3, 2020
@jgrandja jgrandja added the type: enhancement A general enhancement label Nov 3, 2020
@jgrandja jgrandja added this to the 5.5.0-M1 milestone Nov 3, 2020
@jgrandja jgrandja changed the title Token interface for AbstractOAuth2Token OAuth2Token interface for AbstractOAuth2Token Nov 3, 2020
@jgrandja
Copy link
Contributor

jgrandja commented Nov 3, 2020

Extracted the new interface OAuth2Token from AbstractOAuth2Token, which would benefit OAuth2Tokens that was recently introduced in spring-authorization-server#137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants